Issue 100061: Revert r14620 which was a rollback of r14549 and r14508. This

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100061: Revert r14620 which was a rollback of r14549 and r14508. This (Closed)

Created:
11 years, 8 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Revert r14620 which was a rollback of r14549 and r14508. This change re-enables the ui tests. Since jam re-enabled some tests, I had to #ifdef around 4 tests that are not shutting down cleanly on linux. It looks like we have renderers that aren't shutting down properly (pegged at 100% cpu).

Patch Set 1 #

Patch Set 2 : unload tests #

Total comments: 1

Patch Set 3 : rebase #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -14 lines)			Patch
M	base/process_util_posix.cc	View		3 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/app_modal_dialog_gtk.cc	View		1 chunk	+17 lines, -4 lines	0 comments	Download
M	chrome/browser/unload_uitest.cc	View	1 2	8 chunks	+21 lines, -7 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

11 years, 8 months ago (2009-04-27 22:23:25 UTC) #2

lgtm

http://codereview.chromium.org/100061/diff/10/1003
File chrome/browser/unload_uitest.cc (right):

http://codereview.chromium.org/100061/diff/10/1003#newcode233
Line 233: #endif
  // defined(OS_WIN)

Expand Messages | Collapse Messages