Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 10006041: Remove PrerenderResourceThrottle and related infrastructure. (Closed)

Created:
8 years, 8 months ago by cbentzel
Modified:
8 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, dominich+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove PrerenderResourceThrottle and related infrastructure. This was needed in the past to prevent double GETs for the top-level resource of a prerendered page (once when the page started being prerendered, another time when the page was navigated to but before the prerender was swapped in). Now that prerenders are swapped in at OpenURL time, the second GET will not happen and this class is not needed anymore. BUG=122410 TEST=existing tests, do a prerender and confirm that there is not a double-GET of the top-level resource by looking at net-internals. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131602

Patch Set 1 #

Total comments: 3

Patch Set 2 : More uprooting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -308 lines) Patch
M chrome/browser/prerender/prerender_contents.cc View 1 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/prerender/prerender_resource_throttle.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/prerender/prerender_resource_throttle.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/browser/prerender/prerender_tracker.h View 1 4 chunks +0 lines, -36 lines 0 comments Download
M chrome/browser/prerender/prerender_tracker.cc View 1 3 chunks +0 lines, -113 lines 0 comments Download
M chrome/browser/prerender/prerender_tracker_unittest.cc View 1 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
cbentzel
mmenke: Review the whole thing. darin: You're in chrome/OWNERS and originally wrote the throttle. Just ...
8 years, 8 months ago (2012-04-06 19:26:31 UTC) #1
mmenke
http://codereview.chromium.org/10006041/diff/1/chrome/browser/prerender/prerender_tracker.h File chrome/browser/prerender/prerender_tracker.h (right): http://codereview.chromium.org/10006041/diff/1/chrome/browser/prerender/prerender_tracker.h#newcode13 chrome/browser/prerender/prerender_tracker.h:13: #include "base/callback_forward.h" We don't need this anymore. http://codereview.chromium.org/10006041/diff/1/chrome/browser/prerender/prerender_tracker.h#newcode50 chrome/browser/prerender/prerender_tracker.h:50: ...
8 years, 8 months ago (2012-04-06 19:40:04 UTC) #2
darin (slow to review)
cool, LGTM
8 years, 8 months ago (2012-04-07 05:55:42 UTC) #3
cbentzel
Matt - any concerns before I land this?
8 years, 8 months ago (2012-04-10 17:13:10 UTC) #4
mmenke
On 2012/04/10 17:13:10, cbentzel wrote: > Matt - any concerns before I land this? Sorry, ...
8 years, 8 months ago (2012-04-10 17:16:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/10006041/6001
8 years, 8 months ago (2012-04-10 17:18:35 UTC) #6
commit-bot: I haz the power
Try job failure for 10006041-6001 on linux_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=16537 Step "update" is always ...
8 years, 8 months ago (2012-04-10 17:37:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/10006041/6001
8 years, 8 months ago (2012-04-10 17:43:20 UTC) #8
commit-bot: I haz the power
8 years, 8 months ago (2012-04-10 19:15:32 UTC) #9
Change committed as 131602

Powered by Google App Engine
This is Rietveld 408576698