Plugins page in BWSI session has unnecessary and misleading UI components

chrome/browser/ui/webui/chromeos/ui_account_tweaks.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/webui/chromeos/ui_account_tweaks.h"
+
+#include "base/bind.h"

[Nikita (slow), 2012/04/06 12:36:09]

Please cleanup headers. You don't need bind related headers, authenticator,
policy etc.

[Denis Kuznetsov (DE-MUC), 2012/04/09 11:21:30]

Done.

+#include "base/bind_helpers.h"
+#include "base/json/json_reader.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/utf_string_conversions.h"
+#include "base/values.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/chromeos/cros_settings.h"
+#include "chrome/browser/chromeos/cros_settings_names.h"
+#include "chrome/browser/chromeos/login/authenticator.h"
+#include "chrome/browser/chromeos/login/user_manager.h"
+#include "chrome/browser/prefs/pref_service.h"
+#include "chrome/browser/policy/browser_policy_connector.h"
+#include "content/public/browser/web_ui.h"
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+
+namespace chromeos {
+
+/**
+ * Fills given dictionary with account status data (whether current user is

[Nikita (slow), 2012/04/06 12:36:09]

This comment should be moved to header.

[Denis Kuznetsov (DE-MUC), 2012/04/09 11:21:30]

Done.

+ * owner/guest, id of the owner).
+ */
+void AddAccountUITweaksLocalizedValues(
+    base::DictionaryValue* localized_strings) {
+  DCHECK(localized_strings);
+
+  std::string owner_email;
+  CrosSettings::Get()->GetString(kDeviceOwner, &owner_email);
+  // Translate owner's email to the display email.
+  std::string display_email =
+      UserManager::Get()->GetUserDisplayEmail(owner_email);
+  localized_strings->SetString("ownerUserId", UTF8ToUTF16(display_email));
+
+  localized_strings->SetString("currentUserIsOwner",
+      UserManager::Get()->IsCurrentUserOwner() ?
+      ASCIIToUTF16("true") : ASCIIToUTF16("false"));
+
+  localized_strings->SetString("loggedInAsGuest",
+      chromeos::UserManager::Get()->IsLoggedInAsGuest() ?
+      ASCIIToUTF16("true") : ASCIIToUTF16("false"));
+}
+
+/**
+ * Fills given data source with account status data (whether current user is

[Nikita (slow), 2012/04/06 12:36:09]

Remove / move to header.

[Denis Kuznetsov (DE-MUC), 2012/04/09 11:21:30]

Done.

+ * owner/guest, id of the owner).
+ */
+void AddAccountUITweaksLocalizedValues(
+    ChromeWebUIDataSource* source) {
+  DCHECK(source);
+  DictionaryValue dict;
+  AddAccountUITweaksLocalizedValues(&dict);
+  source->AddLocalizedStrings(dict);
+}
+
+}  // namespace chromeos