When I copied presubmit_unittest.py, I picked the old one. Fix with the lates...

depot_tools/tests/presubmit_unittest.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for presubmit.py and presubmit_canned_checks.py."""
 
 import os
 import StringIO
 import unittest
@@ skipping 42 matching lines @@
     gcl.GetSVNFileProperty = MockGetSVNFileProperty
 
     self.original_ReadFile = gcl.ReadFile
     def MockReadFile(path):
       if path.count('nosuchfile'):
         return None
       elif path.endswith('isdir'):
         self.fail('Should not attempt to read file that is directory.')
       elif path.endswith('PRESUBMIT.py'):
         # used in testDoPresubmitChecks
-        return """
-def CheckChangeOnUpload(input_api, output_api):
-  if not input_api.change.NOSUCHKEY:
-    return [output_api.PresubmitError("!!")]
-  elif not input_api.change.REALLYNOSUCHKEY:
-    return [output_api.PresubmitPromptWarning("??")]
-  elif not input_api.change.REALLYABSOLUTELYNOSUCHKEY:
-    return [output_api.PresubmitPromptWarning("??"),
-            output_api.PresubmitError("XX!!XX")]
-  else:
-    return ()
-"""
+        return ('def CheckChangeOnUpload(input_api, output_api):\n'
+                '  if not input_api.change.NOSUCHKEY:\n'
+                '    return [output_api.PresubmitError("!!")]\n'
+                '  elif not input_api.change.REALLYNOSUCHKEY:\n'
+                '    return [output_api.PresubmitPromptWarning("??")]\n'
+                '  elif not input_api.change.REALLYABSOLUTELYNOSUCHKEY:\n'
+                '    return [output_api.PresubmitPromptWarning("??"),\n'
+                '            output_api.PresubmitError("XX!!XX")]\n'
+                '  else:\n'
+                '    return ()')
       else:
         return 'one:%s\r\ntwo:%s' % (path, path)
     gcl.ReadFile = MockReadFile
 
     self.original_GetRepositoryRoot = gcl.GetRepositoryRoot
     def MockGetRepositoryRoot():
       return ''
     gcl.GetRepositoryRoot = MockGetRepositoryRoot
 
   def tearDown(self):
@@ skipping 208 matching lines @@
     files = [
       ['A', 'haspresubmit\\blat.cc'],
     ]
     ci = gcl.ChangeInfo(name='mychange',
                         description='\n'.join(description_lines),
                         files=files)
 
     output = StringIO.StringIO()
     input = StringIO.StringIO('y\n')
 
-    self.failIf(presubmit.DoPresubmitChecks(ci, False, False, output, input,
-                                            None))
-    self.assertEqual(output.getvalue().count('!!'), 2)
+    self.failIf(presubmit.DoPresubmitChecks(ci, False, False, output, input))
+    self.failUnless(output.getvalue().count('!!'))
 
   def testDoPresubmitChecksPromptsAfterWarnings(self):
     description_lines = ('Hello there',
                          'this is a change',
                          'NOSUCHKEY=http://tracker/123')
     files = [
       ['A', 'haspresubmit\\blat.cc'],
     ]
     ci = gcl.ChangeInfo(name='mychange',
                         description='\n'.join(description_lines),
                         files=files)
 
     output = StringIO.StringIO()
     input = StringIO.StringIO('n\n')  # say no to the warning
 
-    self.failIf(presubmit.DoPresubmitChecks(ci, False, False, output, input,
-                                            None))
-    self.assertEqual(output.getvalue().count('??'), 2)
+    self.failIf(presubmit.DoPresubmitChecks(ci, False, False, output, input))
+    self.failUnless(output.getvalue().count('??'))
 
     output = StringIO.StringIO()
     input = StringIO.StringIO('y\n')  # say yes to the warning
 
     self.failUnless(presubmit.DoPresubmitChecks(ci,
                                                 False,
                                                 False,
                                                 output,
-                                                input,
-                                                None))
+                                                input))
     self.failUnless(output.getvalue().count('??'))
 
   def testDoPresubmitChecksNoWarningPromptIfErrors(self):
     description_lines = ('Hello there',
                          'this is a change',
                          'NOSUCHKEY=http://tracker/123',
                          'REALLYNOSUCHKEY=http://tracker/123')
     files = [
       ['A', 'haspresubmit\\blat.cc'],
     ]
     ci = gcl.ChangeInfo(name='mychange',
                         description='\n'.join(description_lines),
                         files=files)
 
     output = StringIO.StringIO()
     input = StringIO.StringIO()  # should be unused
 
-    self.failIf(presubmit.DoPresubmitChecks(ci, False, False, output, input,
-                                            None))
-    self.assertEqual(output.getvalue().count('??'), 2)
-    self.assertEqual(output.getvalue().count('XX!!XX'), 2)
-    self.assertEqual(output.getvalue().count('(y/N)'), 0)
-
-  def testDoDefaultPresubmitChecks(self):
-    description_lines = ('Hello there',
-                         'this is a change',
-                         'STORY=http://tracker/123')
-    files = [
-      ['A', 'haspresubmit\\blat.cc'],
-    ]
-    ci = gcl.ChangeInfo(name='mychange',
-                        description='\n'.join(description_lines),
-                        files=files)
-
-    output = StringIO.StringIO()
-    input = StringIO.StringIO('y\n')
-    DEFAULT_SCRIPT = """
-def CheckChangeOnUpload(input_api, output_api):
-  return [output_api.PresubmitError("!!")]
-"""
-    def MockReadFile(dummy):
-      return ''
-    gcl.ReadFile = MockReadFile
-    def MockIsFile(dummy):
-      return False
-    os.path.isfile = MockIsFile
-    self.failUnless(presubmit.DoPresubmitChecks(ci, False, False, output, input,
-                                                DEFAULT_SCRIPT))
-    self.failIf(output.getvalue().count('!!') == 1)
+    self.failIf(presubmit.DoPresubmitChecks(ci, False, False, output, input))
+    self.failUnless(output.getvalue().count('??'))
+    self.failUnless(output.getvalue().count('XX!!XX'))
+    self.failIf(output.getvalue().count('(y/N)'))
 
   def testDirectoryHandling(self):
     files = [
       ['A', 'isdir'],
       ['A', 'isdir\\blat.cc'],
     ]
     ci = gcl.ChangeInfo(name='mychange',
                         description='foo',
                         files=files)
     change = presubmit.GclChange(ci)
@@ skipping 297 matching lines @@
     self.failIf(presubmit_canned_checks.CheckTreeIsOpen(
       self.MockInputApi(), presubmit.OutputApi, url='url_to_open', closed='0'
     ))
     self.failUnless(presubmit_canned_checks.CheckTreeIsOpen(
       self.MockInputApi(), presubmit.OutputApi, url='url_to_closed', closed='0'
     ))
 
 
 if __name__ == '__main__':
   unittest.main()