Rename SequencedWorkerPoolTaskRunner to SequencedWorkerPoolSequencedTaskRunner.

Rename SequencedWorkerPoolTaskRunner to SequencedWorkerPoolSequencedTaskRunner.

Move it into anonymous namespace in sequenced_worker_pool.cc.

BUG=122458
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131733

[akalin, 2012-04-07 01:53:45]

Why? There's no need to have the word Sequenced in the name twice.
On Apr 7, 2012 6:28 AM, <mattm@chromium.org> wrote:

> Reviewers: willchan, akalin,
>
> Description:
> Rename SequencedWorkerPoolTaskRunner to SequencedWorkerPoolSequencedTa**
> skRunner.
>
> BUG=122458
> TEST=trybots
>
>
> Please review this at
http://codereview.chromium.**org/10005054/<http://codereview.chromium.org/100...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M base/base.gyp
>  M base/base.gypi
>  M base/threading/sequenced_**worker_pool.cc
>  A + base/threading/sequenced_**worker_pool_sequenced_task_**runner.h
>  A + base/threading/sequenced_**worker_pool_sequenced_task_**runner.cc
>  A + base/threading/sequenced_**worker_pool_sequenced_task_**
> runner_unittest.cc
>  D base/threading/sequenced_**worker_pool_task_runner.h
>  D base/threading/sequenced_**worker_pool_task_runner.cc
>  D base/threading/sequenced_**worker_pool_task_runner_**unittest.cc
>
>
>

[akalin, 2012-04-07 01:53:46]

Oh I see.
On Apr 7, 2012 9:52 AM, akalin@chromium.org wrote:

[akalin, 2012-04-07 21:15:45]

LGTM

[commit-bot: I haz the power, 2012-04-08 03:18:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/10005054/1

[commit-bot: I haz the power, 2012-04-08 03:18:49]

Presubmit check for 10005054-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  base/threading/sequenced_worker_pool.cc:110
    void FlushForTesting(); \
  base/threading/sequenced_worker_pool.cc:112
    void SignalHasWorkForTesting(); \
  base/threading/sequenced_worker_pool.cc:114
    int GetWorkSignalCountForTesting() const; \
  base/threading/sequenced_worker_pool.cc:191
    // FlushForTesting()) until IsIdle() goes to true. \
  base/threading/sequenced_worker_pool.cc:835
    inner_->FlushForTesting(); \
  base/threading/sequenced_worker_pool.cc:839
    inner_->SignalHasWorkForTesting();

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    base

[mattm, 2012-04-10 21:55:45]

Updated with putting things into an anonymous namespace (as suggested on
10021002).

[willchan no longer on Chromium, 2012-04-10 21:59:16]

After the other one lands, if this seems fine when I wake up tomorrow, I'll
approve and send to commit queue.

On Tue, Apr 10, 2012 at 10:55 PM, <mattm@chromium.org> wrote:

> Updated with putting things into an anonymous namespace (as suggested on
> 10021002).
>
>
http://codereview.chromium.**org/10005054/<http://codereview.chromium.org/100...
>

[mattm, 2012-04-10 22:01:42]

On 2012/04/10 21:59:16, willchan wrote:
> After the other one lands, if this seems fine when I wake up tomorrow, I'll
> approve and send to commit queue.
> 
> On Tue, Apr 10, 2012 at 10:55 PM, <mailto:mattm@chromium.org> wrote:
> 
> > Updated with putting things into an anonymous namespace (as suggested on
> > 10021002).
> >
> >
>
http://codereview.chromium.**org/10005054/%3Chttp://codereview.chromium.org/1...>
> >

This is the one that needs to land first :)

[willchan no longer on Chromium, 2012-04-11 06:39:15]

Oh, oops :) LGTM

On Tue, Apr 10, 2012 at 11:01 PM, <mattm@chromium.org> wrote:

> On 2012/04/10 21:59:16, willchan wrote:
>
>> After the other one lands, if this seems fine when I wake up tomorrow,
>> I'll
>> approve and send to commit queue.
>>
>
>  On Tue, Apr 10, 2012 at 10:55 PM, <mailto:mattm@chromium.org> wrote:
>>
>
>  > Updated with putting things into an anonymous namespace (as suggested on
>> > 10021002).
>> >
>> >
>>
>
> http://codereview.chromium.****org/10005054/%3Chttp://coderev**
> iew.chromium.org/10005054/ <http://codereview.chromium.org/10005054/>>
>
>> >
>>
>
> This is the one that needs to land first :)
>
>
http://codereview.chromium.**org/10005054/<http://codereview.chromium.org/100...
>

[commit-bot: I haz the power, 2012-04-11 06:40:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/10005054/12001

[commit-bot: I haz the power, 2012-04-11 08:10:14]

Change committed as 131733

[akalin, 2012-08-02 06:55:32]

On 2012/04/11 08:10:14, I haz the power (commit-bot) wrote:
> Change committed as 131733

Looks like this was supposed to delete SWPTaskRunner* but didn't.  Strange.

[mattm, 2012-08-02 20:41:47]

On 2012/08/02 06:55:32, akalin wrote:
> On 2012/04/11 08:10:14, I haz the power (commit-bot) wrote:
> > Change committed as 131733
> 
> Looks like this was supposed to delete SWPTaskRunner* but didn't.  Strange.

Hm, weird indeed.  I'll make a new CL and try again.

[akalin, 2012-08-02 20:46:46]

michaeln@ already has one http://codereview.chromium.org/10831119/ :)

[mattm, 2012-08-02 20:52:03]

On 2012/08/02 20:46:46, akalin wrote:
> michaeln@ already has one http://codereview.chromium.org/10831119/ :)

Ah, cool.  Looking at the revision history it looks like they got resurrected by
https://chromiumcodereview.appspot.com/10572030/ (re-landing of
http://codereview.chromium.org/9703053/) which re-added them after a rebase.