Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: tools/clang/plugins/ChromeClassTester.h

Issue 10005022: Check for public dtors on base::RefCounted types (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/plugins/ChromeClassTester.cpp » ('j') | tools/clang/plugins/FindBadConstructs.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/ChromeClassTester.h
diff --git a/tools/clang/plugins/ChromeClassTester.h b/tools/clang/plugins/ChromeClassTester.h
index 5004f56619fbc13543017ccd33f89d53985fab8c..818da58070d1ca5f1d6b1b0dcdb042317a3d3fd2 100644
--- a/tools/clang/plugins/ChromeClassTester.h
+++ b/tools/clang/plugins/ChromeClassTester.h
@@ -21,8 +21,6 @@ class ChromeClassTester : public clang::ASTConsumer {
explicit ChromeClassTester(clang::CompilerInstance& instance);
virtual ~ChromeClassTester();
- void BuildBannedLists();
-
// ASTConsumer:
virtual void HandleTagDeclDefinition(clang::TagDecl* tag);
@@ -43,7 +41,13 @@ class ChromeClassTester : public clang::ASTConsumer {
// namespace.
bool InBannedNamespace(const clang::Decl* record);
+ // Utility method for subclasses to check if this class is within an
+ // implementation (.cc, .cpp, .mm) file.
+ bool InImplementationFile(const clang::SourceLocation& location);
+
private:
+ void BuildBannedLists();
+
// Filtered versions of tags that are only called with things defined in
// chrome header files.
virtual void CheckChromeClass(const clang::SourceLocation& record_location,
« no previous file with comments | « no previous file | tools/clang/plugins/ChromeClassTester.cpp » ('j') | tools/clang/plugins/FindBadConstructs.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698