tools/clang/plugins/tests/base_refcounted.txt - Issue 10005022: Check for public dtors on base::RefCounted types

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/plugins/tests/base_refcounted.txt

Issue 10005022: Check for public dtors on base::RefCounted types (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Now with moar flags Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 In file included from base_refcounted.cpp:5:

	2 ./base_refcounted.h:44:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors.

	3 ~PublicRefCountedDtorInHeader() {}

	4 ^

	5 ./base_refcounted.h:56:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors.

	6 ~PublicRefCountedThreadSafeDtorInHeader() {}

	7 ^

	8 ./base_refcounted.h:93:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors.

	9 ~DerivedProtectedToPublicInHeader() {}

	10 ^

	11 ./base_refcounted.h:98:1: warning: [chromium-style] Classes that are ref-counted should have explicit destructors that are protected or private.

	12 class ImplicitDerivedProtectedToPublicInHeader

	13 ^

	14 base_refcounted.cpp:16:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors.

	15 ~AnonymousDerivedProtectedToPublicInImpl() {}

	16 ^

	17 base_refcounted.cpp:26:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors.

	18 ~PublicRefCountedDtorInImpl() {}

	19 ^

	20 base_refcounted.cpp:52:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors.

	21 ~UnsafeTypedefChainInImpl() {}

	22 ^

	23 7 warnings generated.

OLD	NEW