Check for public dtors on base::RefCounted types

tools/clang/plugins/ChromeClassTester.cpp

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A general interface for filtering and only acting on classes in Chromium C++
 // code.
 
 #include "ChromeClassTester.h"
 
 #include <sys/param.h>
 
+#include <string>
+
 #include "clang/Basic/FileManager.h"
 
 using namespace clang;
 
 namespace {
 
 bool starts_with(const std::string& one, const std::string& two) {
   return one.compare(0, two.size(), two) == 0;
 }
 
@@ skipping 142 matching lines @@
 bool ChromeClassTester::InBannedNamespace(const Decl* record) {
   std::string n = GetNamespace(record);
   if (n != "") {
     return std::find(banned_namespaces_.begin(), banned_namespaces_.end(), n)
         != banned_namespaces_.end();
   }
 
   return false;
 }
 
+bool ChromeClassTester::InImplementationFile(
+    const SourceLocation& record_location) {
+  const SourceManager &SM = instance().getSourceManager();
+  SourceLocation spelling_location = SM.getSpellingLoc(record_location);
+  PresumedLoc ploc = SM.getPresumedLoc(spelling_location);
+  if (ploc.isInvalid())
+    return false;
+
+  std::string b = ploc.getFilename();
+
+  if (ends_with(b, ".cc") || ends_with(b, ".cpp") || ends_with(b, ".mm"))
+    return true;
+
+  return false;
+}
+
 std::string ChromeClassTester::GetNamespace(const Decl* record) {
   return GetNamespaceImpl(record->getDeclContext(), "");
 }
 
 std::string ChromeClassTester::GetNamespaceImpl(const DeclContext* context,
                                                 std::string candidate) {
   switch (context->getDeclKind()) {
     case Decl::TranslationUnit: {
       return candidate;
     }
@@ skipping 26 matching lines @@
     return true;
   } else {
     std::string b = ploc.getFilename();
 
     // We need to special case scratch space; which is where clang does its
     // macro expansion. We explicitly want to allow people to do otherwise bad
     // things through macros that were defined due to third party libraries.
     if (b == "<scratch space>")
       return true;
 
-    // Don't complain about these things in implementation files.
-    if (ends_with(b, ".cc") || ends_with(b, ".cpp") || ends_with(b, ".mm")) {
-      return true;
-    }
-
     // Don't complain about autogenerated protobuf files.
     if (ends_with(b, ".pb.h")) {
       return true;
     }
 
     // We need to munge the paths so that they are relative to the repository
     // srcroot. We first resolve the symlinktastic relative path and then
     // remove our known srcroot from it if needed.
     char resolvedPath[MAXPATHLEN];
     if (realpath(b.c_str(), resolvedPath)) {
@@ skipping 20 matching lines @@
       }
     }
   }
 
   return false;
 }
 
 bool ChromeClassTester::IsIgnoredType(const std::string& base_name) {
   return ignored_record_names_.find(base_name) != ignored_record_names_.end();
 }