Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Unified Diff: base/message_pump_libevent_unittest.cc

Issue 10004001: Add virtual and OVERRIDE to base/ implementation files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win Fix -> Missing header Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop_unittest.cc ('k') | base/metrics/stats_table_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_pump_libevent_unittest.cc
diff --git a/base/message_pump_libevent_unittest.cc b/base/message_pump_libevent_unittest.cc
index c3ec97e3a3fc0c6e5d4cf7aee1a93b3fef2fdfc6..19a2084218e5af451a2e87b7858a33f0bcd47794 100644
--- a/base/message_pump_libevent_unittest.cc
+++ b/base/message_pump_libevent_unittest.cc
@@ -25,7 +25,7 @@ class MessagePumpLibeventTest : public testing::Test {
io_thread_("MessagePumpLibeventTestIOThread") {}
virtual ~MessagePumpLibeventTest() {}
- virtual void SetUp() {
+ virtual void SetUp() OVERRIDE {
Thread::Options options(MessageLoop::TYPE_IO, 0);
ASSERT_TRUE(io_thread_.StartWithOptions(options));
ASSERT_EQ(MessageLoop::TYPE_IO, io_thread_.message_loop()->type());
@@ -55,8 +55,8 @@ class StupidWatcher : public MessagePumpLibevent::Watcher {
virtual ~StupidWatcher() {}
// base:MessagePumpLibevent::Watcher interface
- virtual void OnFileCanReadWithoutBlocking(int fd) {}
- virtual void OnFileCanWriteWithoutBlocking(int fd) {}
+ virtual void OnFileCanReadWithoutBlocking(int fd) OVERRIDE {}
+ virtual void OnFileCanWriteWithoutBlocking(int fd) OVERRIDE {}
};
#if GTEST_HAS_DEATH_TEST && !defined(NDEBUG)
@@ -85,10 +85,10 @@ class DeleteWatcher : public MessagePumpLibevent::Watcher {
virtual ~DeleteWatcher() {}
// base:MessagePumpLibevent::Watcher interface
- virtual void OnFileCanReadWithoutBlocking(int /* fd */) {
+ virtual void OnFileCanReadWithoutBlocking(int /* fd */) OVERRIDE {
NOTREACHED();
}
- virtual void OnFileCanWriteWithoutBlocking(int /* fd */) {
+ virtual void OnFileCanWriteWithoutBlocking(int /* fd */) OVERRIDE {
delete controller_;
}
@@ -118,10 +118,10 @@ class StopWatcher : public MessagePumpLibevent::Watcher {
virtual ~StopWatcher() {}
// base:MessagePumpLibevent::Watcher interface
- virtual void OnFileCanReadWithoutBlocking(int /* fd */) {
+ virtual void OnFileCanReadWithoutBlocking(int /* fd */) OVERRIDE {
NOTREACHED();
}
- virtual void OnFileCanWriteWithoutBlocking(int /* fd */) {
+ virtual void OnFileCanWriteWithoutBlocking(int /* fd */) OVERRIDE {
controller_->StopWatchingFileDescriptor();
}
« no previous file with comments | « base/message_loop_unittest.cc ('k') | base/metrics/stats_table_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698