Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1282)

Unified Diff: base/file_descriptor_shuffle_unittest.cc

Issue 10004001: Add virtual and OVERRIDE to base/ implementation files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win Fix -> Missing header Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/environment.cc ('k') | base/file_path_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_descriptor_shuffle_unittest.cc
diff --git a/base/file_descriptor_shuffle_unittest.cc b/base/file_descriptor_shuffle_unittest.cc
index 9b3f9597c649caf09cbe0b7963ec6cc9185c995d..a1b1d29ac18d6ecde8a6c2068fa40885d1c6151b 100644
--- a/base/file_descriptor_shuffle_unittest.cc
+++ b/base/file_descriptor_shuffle_unittest.cc
@@ -44,18 +44,18 @@ class InjectionTracer : public InjectionDelegate {
: next_duplicate_(kDuplicateBase) {
}
- bool Duplicate(int* result, int fd) {
+ virtual bool Duplicate(int* result, int fd) OVERRIDE {
*result = next_duplicate_++;
actions_.push_back(Action(Action::DUPLICATE, *result, fd));
return true;
}
- bool Move(int src, int dest) {
+ virtual bool Move(int src, int dest) OVERRIDE {
actions_.push_back(Action(Action::MOVE, src, dest));
return true;
}
- void Close(int fd) {
+ virtual void Close(int fd) OVERRIDE {
actions_.push_back(Action(Action::CLOSE, fd));
}
@@ -250,16 +250,15 @@ TEST(FileDescriptorShuffleTest, FanoutAndClose3) {
class FailingDelegate : public InjectionDelegate {
public:
- bool Duplicate(int* result, int fd) {
+ virtual bool Duplicate(int* result, int fd) OVERRIDE {
return false;
}
- bool Move(int src, int dest) {
+ virtual bool Move(int src, int dest) OVERRIDE {
return false;
}
- void Close(int fd) {
- }
+ virtual void Close(int fd) OVERRIDE {}
};
TEST(FileDescriptorShuffleTest, EmptyWithFailure) {
« no previous file with comments | « base/environment.cc ('k') | base/file_path_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698