base/values_unittest.cc - Issue 10004001: Add virtual and OVERRIDE to base/ implementation files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values_unittest.cc

Issue 10004001: Add virtual and OVERRIDE to base/ implementation files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Feedback from chromium-dev Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/values_unittest.cc

diff --git a/base/values_unittest.cc b/base/values_unittest.cc

index ff6f4a50284c41dab6a0e86b151ee4644385f796..a3d81f8e616345d2bb3e331f2ba7280260e6ebe4 100644

--- a/base/values_unittest.cc

+++ b/base/values_unittest.cc

@@ -175,7 +175,7 @@ class DeletionTestValue : public Value {

*deletion_flag_ = false;

}

- ~DeletionTestValue() {

+ virtual ~DeletionTestValue() {

*deletion_flag_ = true;

}