Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: base/shared_memory_unittest.cc

Issue 10004001: Add virtual and OVERRIDE to base/ implementation files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Feedback from chromium-dev Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/shared_memory_unittest.cc
diff --git a/base/shared_memory_unittest.cc b/base/shared_memory_unittest.cc
index fd88274b5458748535539e3a7e7eb2b87ee3d733..b8b5d80703098560f00113cdf4d8955d6c2878f4 100644
--- a/base/shared_memory_unittest.cc
+++ b/base/shared_memory_unittest.cc
@@ -35,7 +35,7 @@ namespace {
class MultipleThreadMain : public PlatformThread::Delegate {
public:
explicit MultipleThreadMain(int16 id) : id_(id) {}
- ~MultipleThreadMain() {}
+ virtual ~MultipleThreadMain() {}
static void CleanUp() {
SharedMemory memory;
@@ -43,7 +43,7 @@ class MultipleThreadMain : public PlatformThread::Delegate {
}
// PlatformThread::Delegate interface.
- void ThreadMain() {
+ virtual void ThreadMain() OVERRIDE {
#if defined(OS_MACOSX)
mac::ScopedNSAutoreleasePool pool;
#endif
@@ -89,10 +89,10 @@ const char* const MultipleThreadMain::s_test_name_ =
class MultipleLockThread : public PlatformThread::Delegate {
public:
explicit MultipleLockThread(int id) : id_(id) {}
- ~MultipleLockThread() {}
+ virtual ~MultipleLockThread() {}
// PlatformThread::Delegate interface.
- void ThreadMain() {
+ virtual void ThreadMain() OVERRIDE {
const uint32 kDataSize = sizeof(int);
SharedMemoryHandle handle = NULL;
{

Powered by Google App Engine
This is Rietveld 408576698