base/memory/weak_ptr_unittest.cc - Issue 10004001: Add virtual and OVERRIDE to base/ implementation files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/weak_ptr_unittest.cc

Issue 10004001: Add virtual and OVERRIDE to base/ implementation files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Feedback from chromium-dev Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/memory/weak_ptr_unittest.cc

diff --git a/base/memory/weak_ptr_unittest.cc b/base/memory/weak_ptr_unittest.cc

index 8f42664ee244a486b433b70837d2722d477a87ec..ec4c9fe8efe32d38a07ced15d787cb93a5cce8ac 100644

--- a/base/memory/weak_ptr_unittest.cc

+++ b/base/memory/weak_ptr_unittest.cc

@@ -48,7 +48,7 @@ class BackgroundThread : public Thread {

: Thread("owner_thread") {

jar (doing other things) 2012/04/05 21:11:30 nit: You may as well put this all on one line whil

}

- ~BackgroundThread() {

+ virtual ~BackgroundThread() {

Stop();

}