Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10004: Ensure that windowed plugins get focus during WM_MOUSEACTIVATE. This fixes... (Closed)

Created:
12 years, 1 month ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Ensure that windowed plugins get focus during WM_MOUSEACTIVATE. This fixes bug http://code.google.com/p/chromium/issues/detail?id=4273, which shows up when windowed plugins enter modal loops like context menu and keyboard navigation does not work in the menu. We were not converting the coordinates returned by GetCursorPos to client coordinates correctly, which caused us to miss the child window (Plugin) at times. This also fixes bug http://code.google.com/p/chromium/issues/detail?id=937, which was an issue with menu selections in Java menus. This occured because we would force the child window to have focus in every WM_MOUSEACTIVATE message. In this case the Java plugin window, which is a child of the plugin window already has focus. It receives a WM_KILLFOCUS message due to the forced SetFocus in our handler and takes out the menu, thus ignoring the menu selection. Fix for this issue is to handle WM_MOUSEACTIVATE only if a child window of RenderWidgetHostHWND does not have focus. R=amit Bug=4273 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5178

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M chrome/browser/render_widget_host_view_win.cc View 1 2 1 chunk +20 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ananta
12 years, 1 month ago (2008-11-10 20:00:05 UTC) #1
amit
LGTM
12 years, 1 month ago (2008-11-10 22:46:19 UTC) #2
ananta
Updated this CB to add a fix for the menu selection issues as reported in ...
12 years, 1 month ago (2008-11-11 00:13:43 UTC) #3
amit
12 years, 1 month ago (2008-11-11 00:18:48 UTC) #4
ok

Powered by Google App Engine
This is Rietveld 408576698