Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 100037: Update V8 in chromium to version 1.2.1.... (Closed)

Created:
11 years, 8 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Update V8 in chromium to version 1.2.1. Only small changes to the V8 code base itself. The main reason for this push is to get the V8 latest builder working again and to move the v8.gyp file to the v8 sources to make DEPS rolls easier. Updated all references to v8.gyp and the generated projects. Added a missing dependency to chrome.sln: mksnapshot depends on v8_nosnapshot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14595

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1349 lines, -2038 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/all.gyp View 1 chunk +1 line, -1 line 0 comments Download
D build/temp_gyp/v8.gyp View 1 chunk +0 lines, -684 lines 0 comments Download
M chrome/chrome.sln View 24 chunks +1341 lines, -1346 lines 0 comments Download
M net/net.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webkit/webkit.sln View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
11 years, 8 months ago (2009-04-27 10:00:47 UTC) #1
Søren Thygesen Gjesse
LGTM It is a bit difficult to review the dependency changes in chrome.sln. Did webkit.sln ...
11 years, 8 months ago (2009-04-27 10:50:24 UTC) #2
Mads Ager (chromium)
11 years, 8 months ago (2009-04-27 10:58:06 UTC) #3
On 2009/04/27 10:50:24, Søren Gjesse wrote:
> It is a bit difficult to review the dependency changes in chrome.sln. Did
> webkit.sln already have mksnapshot depending on v8_nosnapshot?

Yes, webkit.sln has that dependency already.

> How about the different naming v8/v8_nosnapshot and v8_snapshot/v8 in our
> current Visual Studio project names/the gyp file project names?

Maybe, I actually like the gyp naming where v8 means with snapshots.  Let's
worry about that later when maybe merging the two?  For now, I would like to get
this V8 update in there with a gyp file that is close to what was there.

I deleted the temp_gyp/v8.gyp file as well since it is no longer used.

Powered by Google App Engine
This is Rietveld 408576698