Issue 100035: Add gyp file to v8 repository....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100035: Add gyp file to v8 repository.... (Closed)

Created:
11 years, 8 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Christian Plesner Hansen, bradnelson

CC:
v8-dev, Erik does not do reviews, M-A Ruel

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add gyp file to v8 repository. Gyp is used to generate project files used to build chromium. Moving the v8.gyp file to the v8 repository makes it easier to have V8 and the v8.gyp file synchronized (so a DEPS update in chromium gets the right v8.gyp file associated with that revision of V8). Comitted in v8 revision 1795.

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+709 lines, -0 lines)			Patch
	A	tools/gyp/v8.gyp	View	1	1 chunk	+709 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

Rubber-stamp lgtm. I've looked through the file but probably wouldn't be able to spot errors ...

11 years, 8 months ago (2009-04-27 08:49:37 UTC) #2

Mark Mentovai

11 years, 7 months ago (2009-04-29 16:48:25 UTC) #3

Looks like you didn't set svn:ignore on tools/gyp for the files that will be
generated by GYP from v8.gyp.  This causes generated files to show up as "?" in
"svn status" output, which in turn will cause the try servers to remove the
generated files when they run "gclient revert" to clean up the environment
between try runs.

Expand Messages | Collapse Messages