Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 100034: Support afterCompile event (Closed)

Created:
11 years, 8 months ago by yurys
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

1. Send 'afterCompile' event to the debug message handler.2. Process messages from the debugger command queue on each event not only break and exception.3. auto_continue is always true for compilation events. Committed: http://code.google.com/p/v8/source/detail?r=1801

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 8

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -28 lines) Patch
M src/debug.cc View 1 2 3 7 chunks +21 lines, -22 lines 0 comments Download
M src/debug-delay.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 1 2 5 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
11 years, 8 months ago (2009-04-27 08:39:09 UTC) #1
Søren Thygesen Gjesse
I don't like the idea that some events results in the VM being stopped (break ...
11 years, 8 months ago (2009-04-27 11:00:05 UTC) #2
yurys
Addressed all comments. The running property is true for the copile events. http://codereview.chromium.org/100034/diff/10/1006 File src/debug.cc ...
11 years, 8 months ago (2009-04-27 11:42:18 UTC) #3
Søren Thygesen Gjesse
11 years, 8 months ago (2009-04-27 12:34:43 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698