Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3672)

Unified Diff: chrome/browser/renderer_host/render_view_host_delegate.h

Issue 100033: Synchronously update the loading state when a load starts so that the UI will... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_view_host_delegate.h
===================================================================
--- chrome/browser/renderer_host/render_view_host_delegate.h (revision 14707)
+++ chrome/browser/renderer_host/render_view_host_delegate.h (working copy)
@@ -198,13 +198,13 @@
// The page is trying to move the RenderView's representation in the client.
virtual void RequestMove(const gfx::Rect& new_bounds) { }
- // The RenderView began loading a new page.
- virtual void DidStartLoading(RenderViewHost* render_view_host,
- int32 page_id) { }
+ // The RenderView began loading a new page. This corresponds to WebKit's
+ // notion of the throbber starting.
+ virtual void DidStartLoading(RenderViewHost* render_view_host) { }
- // The RenderView stopped loading a page.
- virtual void DidStopLoading(RenderViewHost* render_view_host,
- int32 page_id) { }
+ // The RenderView stopped loading a page. This corresponds to WebKit's
+ // notion of the throbber stopping.
+ virtual void DidStopLoading(RenderViewHost* render_view_host) { }
// The RenderView is starting a provisional load.
virtual void DidStartProvisionalLoadForFrame(RenderViewHost* render_view_host,
« no previous file with comments | « chrome/browser/renderer_host/render_view_host.cc ('k') | chrome/browser/tab_contents/render_view_host_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698