chrome/browser/tab_contents/tab_contents.h - Issue 100033: Synchronously update the loading state when a load starts so that the UI will...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/tab_contents.h

Issue 100033: Synchronously update the loading state when a load starts so that the UI will... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/tab_contents/tab_contents.h

===================================================================

--- chrome/browser/tab_contents/tab_contents.h (revision 14707)

+++ chrome/browser/tab_contents/tab_contents.h (working copy)

@@ -748,8 +748,8 @@

const ThumbnailScore& score);

virtual void Close(RenderViewHost* render_view_host);

virtual void RequestMove(const gfx::Rect& new_bounds);

- virtual void DidStartLoading(RenderViewHost* render_view_host, int32 page_id);

- virtual void DidStopLoading(RenderViewHost* render_view_host, int32 page_id);

+ virtual void DidStartLoading(RenderViewHost* render_view_host);

+ virtual void DidStopLoading(RenderViewHost* render_view_host);

virtual void DidStartProvisionalLoadForFrame(RenderViewHost* render_view_host,

bool is_main_frame,

const GURL& url);

@@ -850,8 +850,8 @@

bool proceed,

bool* proceed_to_fire_unload);

virtual void DidStartLoadingFromRenderManager(

- RenderViewHost* render_view_host, int32 page_id) {

- DidStartLoading(render_view_host, page_id);

+ RenderViewHost* render_view_host) {

+ DidStartLoading(render_view_host);

}

virtual void RenderViewGoneFromRenderManager(

RenderViewHost* render_view_host) {

« no previous file with comments | « chrome/browser/tab_contents/render_view_host_manager.h ('k') | chrome/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »