Synchronously update the loading state when a load starts so that the UI will...

chrome/renderer/render_view.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/render_view.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 1139 matching lines @@
   if (is_loading_) {
     DLOG(WARNING) << "DidStartLoading called while loading";
     return;
   }
 
   is_loading_ = true;
   // Clear the pointer so that we can assign it only when there is an unknown
   // plugin on a page.
   first_default_plugin_ = NULL;
 
-  Send(new ViewHostMsg_DidStartLoading(routing_id_, page_id_));
+  Send(new ViewHostMsg_DidStartLoading(routing_id_));
 }
 
 void RenderView::DidStopLoading(WebView* webview) {
   if (!is_loading_) {
     DLOG(WARNING) << "DidStopLoading called while not loading";
     return;
   }
 
   is_loading_ = false;
 
   // NOTE: For now we're doing the safest thing, and sending out notification
   // when done loading. This currently isn't an issue as the favicon is only
   // displayed when done loading. Ideally we would send notification when
   // finished parsing the head, but webkit doesn't support that yet.
   // The feed discovery code would also benefit from access to the head.
   GURL favicon_url(webview->GetMainFrame()->GetFavIconURL());
   if (!favicon_url.is_empty())
     Send(new ViewHostMsg_UpdateFavIconURL(routing_id_, page_id_, favicon_url));
 
   AddGURLSearchProvider(webview->GetMainFrame()->GetOSDDURL(),
                         true);  // autodetected
 
-  Send(new ViewHostMsg_DidStopLoading(routing_id_, page_id_));
+  Send(new ViewHostMsg_DidStopLoading(routing_id_));
 
   MessageLoop::current()->PostDelayedTask(FROM_HERE,
       method_factory_.NewRunnableMethod(&RenderView::CapturePageInfo, page_id_,
                                         false),
       kDelayForCaptureMs);
 
   // The page is loaded. Try to process the file we need to upload if any.
   ProcessPendingUpload();
 
   // Since the page is done loading, we are sure we don't need to try
@@ skipping 1804 matching lines @@
     }
   }
   UMA_HISTOGRAM_TIMES("Renderer.All.StartToFinishDoc", start_to_finish_doc);
   UMA_HISTOGRAM_TIMES("Renderer.All.FinishDocToFinish", finish_doc_to_finish);
   UMA_HISTOGRAM_TIMES("Renderer.All.StartToFinish", start_to_finish);
   if (start_to_first_layout.ToInternalValue() >= 0) {
     UMA_HISTOGRAM_TIMES(
       "Renderer.All.StartToFirstLayout", start_to_first_layout);
   }
 }