Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Side by Side Diff: chrome/browser/extensions/extension_view.h

Issue 100033: Synchronously update the loading state when a load starts so that the UI will... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/browser.cc ('k') | chrome/browser/extensions/extension_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_VIEW_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_VIEW_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_VIEW_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_VIEW_H_
7 7
8 #include "chrome/browser/renderer_host/render_view_host_delegate.h" 8 #include "chrome/browser/renderer_host/render_view_host_delegate.h"
9 #include "chrome/browser/tab_contents/render_view_host_delegate_helper.h" 9 #include "chrome/browser/tab_contents/render_view_host_delegate_helper.h"
10 #include "skia/include/SkBitmap.h" 10 #include "skia/include/SkBitmap.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 // HWNDHtmlView 42 // HWNDHtmlView
43 virtual void CreatingRenderer(); 43 virtual void CreatingRenderer();
44 44
45 virtual void SetBackground(const SkBitmap& background); 45 virtual void SetBackground(const SkBitmap& background);
46 46
47 // RenderViewHostDelegate 47 // RenderViewHostDelegate
48 // TODO(mpcomplete): GetProfile is unused. 48 // TODO(mpcomplete): GetProfile is unused.
49 virtual Profile* GetProfile() const { return NULL; } 49 virtual Profile* GetProfile() const { return NULL; }
50 virtual void RenderViewCreated(RenderViewHost* render_view_host); 50 virtual void RenderViewCreated(RenderViewHost* render_view_host);
51 virtual void DidContentsPreferredWidthChange(const int pref_width); 51 virtual void DidContentsPreferredWidthChange(const int pref_width);
52 virtual void DidStopLoading(RenderViewHost* render_view_host, 52 virtual void DidStopLoading(RenderViewHost* render_view_host);
53 int32 page_id);
54 virtual WebPreferences GetWebkitPrefs(); 53 virtual WebPreferences GetWebkitPrefs();
55 virtual void RunJavaScriptMessage( 54 virtual void RunJavaScriptMessage(
56 const std::wstring& message, 55 const std::wstring& message,
57 const std::wstring& default_prompt, 56 const std::wstring& default_prompt,
58 const GURL& frame_url, 57 const GURL& frame_url,
59 const int flags, 58 const int flags,
60 IPC::Message* reply_msg, 59 IPC::Message* reply_msg,
61 bool* did_suppress_message); 60 bool* did_suppress_message);
62 virtual void DidStartLoading(RenderViewHost* render_view_host, 61 virtual void DidStartLoading(RenderViewHost* render_view_host);
63 int32 page_id);
64 virtual RenderViewHostDelegate::View* GetViewDelegate() const; 62 virtual RenderViewHostDelegate::View* GetViewDelegate() const;
65 63
66 // RenderViewHostDelegate::View 64 // RenderViewHostDelegate::View
67 virtual void CreateNewWindow(int route_id, 65 virtual void CreateNewWindow(int route_id,
68 base::WaitableEvent* modal_dialog_event); 66 base::WaitableEvent* modal_dialog_event);
69 virtual void CreateNewWidget(int route_id, bool activatable); 67 virtual void CreateNewWidget(int route_id, bool activatable);
70 virtual void ShowCreatedWindow(int route_id, 68 virtual void ShowCreatedWindow(int route_id,
71 WindowOpenDisposition disposition, 69 WindowOpenDisposition disposition,
72 const gfx::Rect& initial_pos, 70 const gfx::Rect& initial_pos,
73 bool user_gesture); 71 bool user_gesture);
(...skipping 22 matching lines...) Expand all
96 bool did_stop_loading_; 94 bool did_stop_loading_;
97 95
98 // What we should set the preferred width to once the ExtensionView has 96 // What we should set the preferred width to once the ExtensionView has
99 // loaded. 97 // loaded.
100 int pending_preferred_width_; 98 int pending_preferred_width_;
101 99
102 DISALLOW_COPY_AND_ASSIGN(ExtensionView); 100 DISALLOW_COPY_AND_ASSIGN(ExtensionView);
103 }; 101 };
104 102
105 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_VIEW_H_ 103 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/browser.cc ('k') | chrome/browser/extensions/extension_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698