Should handle the events when no printer is detected on local machine...

Should handle the events when no printer is detected on local machine

GetDefaultPrintSettings was returning an empty struct because no printer is installed. Checking when its empty will allow us to know that a printer is missing on that system. There is clearly no other way to do this, unless we do not do all those dchecks on dpi and other struct members.

BUG=6835
TEST=Tested only on windows, since linux/mac printing not even implemented. Removed all printer drivers, opened chromium, and ran a print job, popup dialog appeared stating no printer installed. Installed my printer drivers again, print dialog appeared.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14731

[M-A Ruel, 2009-04-26 22:56:04]

lgtm, ping me if not checked-in on Monday.

[Sverrir, 2009-04-27 17:36:55]

LGTM

Quick questions: this method of triggering javascript popups is not used
anywhere in our codebase?  
And: We need to translate this message?  And possibly make it more *fun*
(possibly involve someone from UX)?

[M-A Ruel, 2009-04-27 17:59:40]

On 2009/04/27 17:36:55, Sverrir wrote:
> LGTM
> 
> Quick questions: this method of triggering javascript popups is not used
> anywhere in our codebase?  
> And: We need to translate this message?  And possibly make it more *fun*
> (possibly involve someone from UX)?

yep, this needs to be translated. I totally forgot about it. Since the renderer
has access to the chrome.dll resources, it should be relatively easy.

Mohamed, can you do that before I check that in? I'd rather not include an
hard-coded string.

[Mohamed Mansour (USE mhm), 2009-04-27 19:06:40]

Ah sorry :( I totally forgot about translation. I will properly do that when I
get home after work. I do not have to translate all ~40 languages, do I ? Time
to learn all languages hrhr (jk)

[M-A Ruel, 2009-04-27 19:13:32]

On 2009/04/27 19:06:40, Mohamed Mansour wrote:
> Ah sorry :( I totally forgot about translation. I will properly do that when I
> get home after work. I do not have to translate all ~40 languages, do I ? Time
> to learn all languages hrhr (jk)

No, you just add your string in generated_resources.grd. generated_resources.h
is already included in render_view.cc

[Mohamed Mansour (USE mhm), 2009-04-27 23:27:49]

Alright done, followed the document here:
http://dev.chromium.org/developers/design-documents/ui-localization

[Sverrir, 2009-04-28 13:59:54]

LGTM

Suggested alternate text for the message.

[Sverrir, 2009-04-28 14:00:19]

http://codereview.chromium.org/100023/diff/10/1006
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/100023/diff/10/1006#newcode2371
Line 2371: No printer found, Please install a printer.
Alternate suggestion:
No printer detected.  Please connect a printer or find yourself a pen and paper.