Allow words to be wrapped in message box....

Allow words to be wrapped in message box.

We use DT_WORDBREK|DT_EDITCONTROL as the argument of DrawText().
With this option, DrawText() try to wrap texts at word-breaks first,
then wraps at non-word-breaks if one line is still too long.

This change only affects for Labels in MessageBox.
If we can always use this policy, please let me know
and I'll fix the code.

BUG=2441

[Ben Goodger (Google), 2009-04-27 18:31:57]

OK, just nits.

http://codereview.chromium.org/100013/diff/1/2
File chrome/common/gfx/chrome_canvas.h (right):

http://codereview.chromium.org/100013/diff/1/2#newcode63
Line 63: // Specifies if words can be splitted by new lines.
nit: split

http://codereview.chromium.org/100013/diff/1/3
File chrome/common/gfx/chrome_canvas_win.cc (right):

http://codereview.chromium.org/100013/diff/1/3#newcode57
Line 57: if (flags & ChromeCanvas::CHARACTER_BREAK) {
nit: no braces for single line if

http://codereview.chromium.org/100013/diff/1/4
File chrome/views/controls/label.cc (right):

http://codereview.chromium.org/100013/diff/1/4#newcode84
Line 84: if (allow_character_break_) {
nit: no { on single line if

http://codereview.chromium.org/100013/diff/1/5
File chrome/views/controls/label.h (right):

http://codereview.chromium.org/100013/diff/1/5#newcode127
Line 127: // Set whether the label text can be splitted in words.
nit: split on words

[hamaji, 2009-04-27 18:36:54]

Thanks you for the quick review! I fixed all.

http://codereview.chromium.org/100013/diff/1/2
File chrome/common/gfx/chrome_canvas.h (right):

http://codereview.chromium.org/100013/diff/1/2#newcode63
Line 63: // Specifies if words can be splitted by new lines.
On 2009/04/27 18:31:57, Ben Goodger wrote:
> nit: split

Done.

http://codereview.chromium.org/100013/diff/1/3
File chrome/common/gfx/chrome_canvas_win.cc (right):

http://codereview.chromium.org/100013/diff/1/3#newcode57
Line 57: if (flags & ChromeCanvas::CHARACTER_BREAK) {
On 2009/04/27 18:31:57, Ben Goodger wrote:
> nit: no braces for single line if

Done.

http://codereview.chromium.org/100013/diff/1/4
File chrome/views/controls/label.cc (right):

http://codereview.chromium.org/100013/diff/1/4#newcode84
Line 84: if (allow_character_break_) {
On 2009/04/27 18:31:57, Ben Goodger wrote:
> nit: no { on single line if

Done.

http://codereview.chromium.org/100013/diff/1/5
File chrome/views/controls/label.h (right):

http://codereview.chromium.org/100013/diff/1/5#newcode127
Line 127: // Set whether the label text can be splitted in words.
On 2009/04/27 18:31:57, Ben Goodger wrote:
> nit: split on words

Done.

[hamaji, 2009-04-27 18:57:09]

FYI, Build bot ran successfully. If there are no more issues, could you check
this in? I don't have chromium account yet.

Thanks!

On 2009/04/27 18:36:54, hamaji wrote:
> Thanks you for the quick review! I fixed all.
> 
> http://codereview.chromium.org/100013/diff/1/2
> File chrome/common/gfx/chrome_canvas.h (right):
> 
> http://codereview.chromium.org/100013/diff/1/2#newcode63
> Line 63: // Specifies if words can be splitted by new lines.
> On 2009/04/27 18:31:57, Ben Goodger wrote:
> > nit: split
> 
> Done.
> 
> http://codereview.chromium.org/100013/diff/1/3
> File chrome/common/gfx/chrome_canvas_win.cc (right):
> 
> http://codereview.chromium.org/100013/diff/1/3#newcode57
> Line 57: if (flags & ChromeCanvas::CHARACTER_BREAK) {
> On 2009/04/27 18:31:57, Ben Goodger wrote:
> > nit: no braces for single line if
> 
> Done.
> 
> http://codereview.chromium.org/100013/diff/1/4
> File chrome/views/controls/label.cc (right):
> 
> http://codereview.chromium.org/100013/diff/1/4#newcode84
> Line 84: if (allow_character_break_) {
> On 2009/04/27 18:31:57, Ben Goodger wrote:
> > nit: no { on single line if
> 
> Done.
> 
> http://codereview.chromium.org/100013/diff/1/5
> File chrome/views/controls/label.h (right):
> 
> http://codereview.chromium.org/100013/diff/1/5#newcode127
> Line 127: // Set whether the label text can be splitted in words.
> On 2009/04/27 18:31:57, Ben Goodger wrote:
> > nit: split on words
> 
> Done.