Issue 100002: Fix for interstitial reload bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100002: Fix for interstitial reload bug (Closed)

Created:
11 years, 8 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

When navigating from an interstitial to another page with an interstitial, we should not discard the non committed entries, as this would cause the new navigation pending entry to go away. BUG=9791 TEST=Visit a page with an SSL error (ex: https://ebay.com). Focus the location bar and press enter (to navigate again to that page). The interstitial should be shown again and the location bar should show the URL. Also ensure that interstitial pages (SSL and safe browsing) still work as expected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14687

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	chrome/browser/tab_contents/interstitial_page.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/tab_contents/interstitial_page.cc	View		3 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages