Issue 1000007: Fix formatting around * and &.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1000007: Fix formatting around * and &. (Closed)

Created:
10 years, 9 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix formatting around * and &. Committed: http://code.google.com/p/v8/source/detail?r=4169

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -31 lines)			Patch
M	src/arm/macro-assembler-arm.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.h	View	1 chunk	+20 lines, -20 lines	0 comments	Download
M	src/ia32/codegen-ia32.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/serialize.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

10 years, 9 months ago (2010-03-17 13:50:30 UTC) #2

LGTM

But at least two places with incorrect asterisk layout still left. Please see

counters.h:68:  static int *FindLocation(const char* name) {
v8.cc:46:bool V8::Initialize(Deserializer *des) {

On 2010/03/17 13:08:24, Erik Corry wrote:
>

Expand Messages | Collapse Messages