Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 9374030: Move json to lib/json/{json.dart, json_frog.dart} (Closed)

Created:
8 years, 10 months ago by dgrove
Modified:
8 years, 10 months ago
CC:
reviews_dartlang.org, danrubel
Visibility:
Public.

Description

Move json to lib/json/{json.dart, json_frog.dart} Committed: https://code.google.com/p/dart/source/detail?r=4101

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1343 lines) Patch
D client/json/dart_json.dart View 1 2 1 chunk +0 lines, -601 lines 0 comments Download
M compiler/dartc.xml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M compiler/scripts/generate_my_projects.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/features/com.google.dart.tools.deploy.feature_releng/build_rcp.xml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M frog/leg/scanner/source_list.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
D frog/lib/frog_json_sources.gypi View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D frog/lib/json_frog.dart View 1 2 1 chunk +0 lines, -89 lines 0 comments Download
M frog/reader.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D frog/server/dart_json.dart View 1 2 1 chunk +0 lines, -604 lines 0 comments Download
M frog/server/frog_server.dart View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M frog/tests/frog/src/FrogServerTest.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + lib/json/json.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/json/json_frog.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M samples/belay/bcap/bcap_client.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samples/belay/bcap/bcap_fling.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samples/belay/bcap/src/impl_bcap.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samples/belay/tests/bcap_tests.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samples/chat/chat_server_lib.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samples/chat/chat_stress_client.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samples/tests/samples/src/chat/ChatServerTest.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samples/tests/samples/src/chat/HttpTest.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 1 2 5 chunks +13 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dgrove
8 years, 10 months ago (2012-02-09 22:47:36 UTC) #1
dgrove
codereview.chromium.org is not showing completely accurate status. Here's the actual gcl status for this change: ...
8 years, 10 months ago (2012-02-09 22:50:43 UTC) #2
Siggi Cherem (dart-lang)
lgtm
8 years, 10 months ago (2012-02-09 22:50:51 UTC) #3
dgrove
(adding Mark for changes in editor)
8 years, 10 months ago (2012-02-09 23:09:40 UTC) #4
jwren
8 years, 10 months ago (2012-02-09 23:37:31 UTC) #5
On 2012/02/09 23:09:40, dgrove wrote:
> (adding Mark for changes in editor)

Devon (devoncarew) and myself just looked at the change, it doesn't look like it
will break the editor.  If it does, just ping Devon or Mark to fix it.

Powered by Google App Engine
This is Rietveld 408576698