Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 9314025: Remove fling, deftserver (used only by fling), and commons-codec (Closed)

Created:
8 years, 10 months ago by dgrove
Modified:
8 years, 10 months ago
Reviewers:
zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove fling, deftserver (used only by fling), and commons-codec (used only by dartboard). (I'll submit a change to the top-level LICENSE file once this goes in) Committed: https://code.google.com/p/dart/source/detail?r=3854

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3430 lines) Patch
M client/dart.gyp View 1 1 chunk +0 lines, -37 lines 0 comments Download
D client/fling/README.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D client/fling/build.xml View 1 1 chunk +0 lines, -63 lines 0 comments Download
D client/fling/dist/fling View 1 1 chunk +0 lines, -47 lines 0 comments Download
D client/fling/dist/runtime/apps/adminz/adminz.dart View 1 1 chunk +0 lines, -143 lines 0 comments Download
D client/fling/dist/runtime/logback.xml View 1 1 chunk +0 lines, -19 lines 0 comments Download
D client/fling/eclipse/classpath View 1 1 chunk +0 lines, -19 lines 0 comments Download
D client/fling/eclipse/project View 1 1 chunk +0 lines, -17 lines 0 comments Download
D client/fling/eclipse/settings/org.eclipse.jdt.core.prefs View 1 1 chunk +0 lines, -16 lines 0 comments Download
D client/fling/fling.dart View 1 1 chunk +0 lines, -7 lines 0 comments Download
D client/fling/fling.gypi View 1 1 chunk +0 lines, -24 lines 0 comments Download
D client/fling/samples/lil_server.dart View 1 1 chunk +0 lines, -28 lines 0 comments Download
D client/fling/samples/static/index.html View 1 1 chunk +0 lines, -11 lines 0 comments Download
D client/fling/samples/static/lil_client.dart View 1 1 chunk +0 lines, -10 lines 0 comments Download
D client/fling/samples/static/lil_client.js View 1 1 chunk +0 lines, -6 lines 0 comments Download
D client/fling/samples/two_servers.dart View 1 1 chunk +0 lines, -27 lines 0 comments Download
D client/fling/src/dart/fling.dart View 1 1 chunk +0 lines, -67 lines 0 comments Download
D client/fling/src/dart/fling.js View 1 1 chunk +0 lines, -95 lines 0 comments Download
D client/fling/src/java/core/com/google/dart/CompileError.java View 1 1 chunk +0 lines, -72 lines 0 comments Download
D client/fling/src/java/core/com/google/dart/CompileResult.java View 1 1 chunk +0 lines, -71 lines 0 comments Download
D client/fling/src/java/core/com/google/dart/CompileService.java View 1 1 chunk +0 lines, -274 lines 0 comments Download
D client/fling/src/java/core/com/google/dart/LibraryFromSources.java View 1 1 chunk +0 lines, -110 lines 0 comments Download
D client/fling/src/java/core/com/google/dart/SourceFromString.java View 1 1 chunk +0 lines, -60 lines 0 comments Download
D client/fling/src/java/core/com/google/dart/fling/Environment.java View 1 1 chunk +0 lines, -147 lines 0 comments Download
D client/fling/src/java/core/com/google/dart/fling/Fling.java View 1 1 chunk +0 lines, -67 lines 0 comments Download
D client/fling/src/java/core/com/google/dart/fling/Http.java View 1 1 chunk +0 lines, -554 lines 0 comments Download
D client/fling/src/java/core/com/google/dart/fling/MessageLoop.java View 1 1 chunk +0 lines, -178 lines 0 comments Download
D client/fling/src/java/core/com/google/dart/fling/PrefixTree.java View 1 1 chunk +0 lines, -115 lines 0 comments Download
D client/fling/src/java/core/com/google/dart/fling/RhinoUtil.java View 1 1 chunk +0 lines, -17 lines 0 comments Download
D client/fling/src/java/test/com/google/dart/fling/MessageLoopTest.java View 1 1 chunk +0 lines, -49 lines 0 comments Download
M dart.gyp View 1 1 chunk +0 lines, -9 lines 0 comments Download
M frog/leg/scanner/source_list.dart View 1 1 chunk +0 lines, -6 lines 0 comments Download
M samples/total/client/Server.dart View 1 2 3 1 chunk +0 lines, -23 lines 0 comments Download
M samples/total/server/TotalRunner.dart View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/commons-codec/1.5/LICENSE.txt View 1 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/commons-codec/1.5/NOTICE.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/commons-codec/1.5/RELEASE-NOTES.txt View 1 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/commons-codec/1.5/commons-codec-1.5.jar View Binary file 0 comments Download
D third_party/commons-codec/1.5/commons-codec-1.5-javadoc.jar View Binary file 0 comments Download
D third_party/commons-codec/1.5/commons-codec-1.5-sources.jar View Binary file 0 comments Download
D third_party/commons-codec/LICENSE View 1 1 chunk +0 lines, -272 lines 0 comments Download
D third_party/commons-codec/README View 1 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/deftserver/0.4.0-SNAPSHOT/activation-1.1.1.jar View Binary file 0 comments Download
D third_party/deftserver/0.4.0-SNAPSHOT/deft-0.4.0-SNAPSHOT.jar View Binary file 0 comments Download
D third_party/deftserver/0.4.0-SNAPSHOT/logback-classic-0.9.28.jar View Binary file 0 comments Download
D third_party/deftserver/0.4.0-SNAPSHOT/logback-core-0.9.28.jar View Binary file 0 comments Download
D third_party/deftserver/0.4.0-SNAPSHOT/slf4j-api-1.6.1.jar View Binary file 0 comments Download
D third_party/deftserver/LICENSE View 1 1 chunk +0 lines, -446 lines 0 comments Download
D third_party/deftserver/README View 1 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/deftserver/ioloop-reset.diff View 1 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dgrove
8 years, 10 months ago (2012-02-01 02:08:22 UTC) #1
zundel
After applying the patch, here are some things I found: .gitignore has a reference to ...
8 years, 10 months ago (2012-02-02 17:36:47 UTC) #2
zundel
8 years, 10 months ago (2012-02-02 18:03:15 UTC) #3
LGTM,

fyi, the samples/total/Server.dart file can be completely removed.

Powered by Google App Engine
This is Rietveld 408576698