Issue 9234002: Add summary of failures to end of test.dart output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9234002: Add summary of failures to end of test.dart output. (Closed)

Created:
8 years, 11 months ago by Bill Hesse

Modified:
8 years, 11 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add summary of failures to end of test.dart output. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3336

Patch Set 2 : Only print DoneProgress again at bottom if we printed failure logs. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -12 lines)			Patch
	M	tools/testing/dart/test_progress.dart	View	1	6 chunks	+43 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm http://codereview.chromium.org/9234002/diff/1/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (right): http://codereview.chromium.org/9234002/diff/1/tools/testing/dart/test_progress.dart#newcode192 tools/testing/dart/test_progress.dart:192: _printProgress(); Do you really want to print progress ...

8 years, 11 months ago (2012-01-16 10:45:00 UTC) #2

Bill Hesse

8 years, 11 months ago (2012-01-16 11:24:34 UTC) #3

http://codereview.chromium.org/9234002/diff/1/tools/testing/dart/test_progres...
File tools/testing/dart/test_progress.dart (right):

http://codereview.chromium.org/9234002/diff/1/tools/testing/dart/test_progres...
tools/testing/dart/test_progress.dart:192: _printProgress();
It is nice to have that as the last line of the output.  Otherwise, the user has
to scroll up an unknown amount to find the results - they are really hard to
find.

On 2012/01/16 10:45:00, Mads Ager wrote:
> Do you really want to print progress here again? I think I would avoid that
(it
> would duplicate the '[time | percent | pass | fail]' line).

Expand Messages | Collapse Messages

Issue 9234002: Add summary of failures to end of test.dart output. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Only print DoneProgress again at bottom if we printed failure logs. #

Messages