Issue 9222001: cleanup resolveMember and get/set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9222001: cleanup resolveMember and get/set (Closed)

Created:
8 years, 11 months ago by jimhug

Modified:
8 years, 11 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

cleanup resolveMember and get/set Fixes two get/set tests as a result of cleanup and mostly addresses several other issues to be completed in a follow-up commit. This is coming in a little bit early to minimize merge issues as John is making simultaneous great progress. Committed: https://code.google.com/p/dart/source/detail?r=3326

Patch Set 1 #

Patch Set 2 : prereview #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1128 lines, -1045 lines)			Patch
M	frog/gen.dart	View	1	10 chunks	+67 lines, -163 lines	0 comments	Download
M	frog/member.dart	View		5 chunks	+104 lines, -15 lines	0 comments	Download
M	frog/minfrog	View		259 chunks	+767 lines, -743 lines	0 comments	Download
M	frog/tests/frog/frog.status	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	frog/type.dart	View		8 chunks	+25 lines, -48 lines	0 comments	Download
M	frog/value.dart	View	1	6 chunks	+149 lines, -57 lines	0 comments	Download
M	frog/var_member.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	frog/world.dart	View		3 chunks	+9 lines, -10 lines	0 comments	Download
M	tests/language/language.status	View		2 chunks	+0 lines, -2 lines	0 comments	Download