Issue 1164: Out of date system libraries + restarted compiler

Issue 1164: Out of date system libraries + restarted compiler
http://code.google.com/p/dart/issues/detail?id=1164

When the compiler fails to complete compilation, and the system libraries are
not bundled, it will fail to recompile the missing elements.  This was only a
problem in the DartEditor and running DartC from an eclipse environment.

Please note that there still exists a condition if you are running DartC
from eclipse and have system libraries, without precompiled artifacts, in a
jar file.  I will file a separate bug for that.

R=mmendez,brianwilkerson@google.com,danrubel
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3301

[mmendez, 2012-01-13 18:19:54]

lgtm

http://codereview.chromium.org/9212008/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

http://codereview.chromium.org/9212008/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/DartCompiler.java:263: if (apiUnit ==
null || (isSourceOutOfDate(dartSrc, libSrc))) {
Nit: could remove the braces.

http://codereview.chromium.org/9212008/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/UrlSource.java (right):

http://codereview.chromium.org/9212008/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/UrlSource.java:131: URI resolvedUri =
BASE_URI.resolve(translatedUri);
Not for this change but, we need to think about how to clean up this whole
Source hierarchy and these URIs.  This part of the system is quite crufty.

[Brian Wilkerson, 2012-01-13 18:25:46]

LGTM

[codefu, 2012-01-13 18:33:21]

http://codereview.chromium.org/9212008/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

http://codereview.chromium.org/9212008/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/DartCompiler.java:263: if (apiUnit ==
null || (isSourceOutOfDate(dartSrc, libSrc))) {
On 2012/01/13 18:19:55, mmendez wrote:
> Nit: could remove the braces.

Done.