Issue 9211018: Allow non-string values to be passed to setProperty and other CSS properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9211018: Allow non-string values to be passed to setProperty and other CSS properties. (Closed)

Created:
8 years, 11 months ago by nweiz

Modified:
8 years, 11 months ago

Reviewers:
sra1, Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow non-string values to be passed to setProperty and other CSS properties. Fixed issue 825. TBR Committed: https://code.google.com/p/dart/source/detail?r=3321

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1236 lines, -1236 lines)			Patch
M	client/html/release/html.dart	View	1 chunk	+308 lines, -308 lines	0 comments	Download
M	client/html/release/htmlimpl.dart	View	309 chunks	+310 lines, -310 lines	0 comments	Download
M	client/html/src/CSSStyleDeclaration.dart	View	1 chunk	+308 lines, -308 lines	0 comments	Download
M	client/html/src/CSSStyleDeclarationWrappingImplementation.dart	View	309 chunks	+310 lines, -310 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

http://codereview.chromium.org/9211018/diff/1/client/html/src/CSSStyleDeclarationWrappingImplementation.dart File client/html/src/CSSStyleDeclarationWrappingImplementation.dart (right): http://codereview.chromium.org/9211018/diff/1/client/html/src/CSSStyleDeclarationWrappingImplementation.dart#newcode42 client/html/src/CSSStyleDeclarationWrappingImplementation.dart:42: void set cssText(var value) { _ptr.cssText = value; } ...

8 years, 11 months ago (2012-01-14 08:26:24 UTC) #2

nweiz

8 years, 11 months ago (2012-01-17 21:32:19 UTC) #3

http://codereview.chromium.org/9211018/diff/1/client/html/src/CSSStyleDeclara...
File client/html/src/CSSStyleDeclarationWrappingImplementation.dart (right):

http://codereview.chromium.org/9211018/diff/1/client/html/src/CSSStyleDeclara...
client/html/src/CSSStyleDeclarationWrappingImplementation.dart:42: void set
cssText(var value) { _ptr.cssText = value; }
On 2012/01/14 08:26:25, sra1 wrote:
> Missing conversion to string?

Good catch. This should actually only take a String; it got caught in my
search/replace accidentally.

Expand Messages | Collapse Messages