Issue 9203004: - Remove support for ">>>" operator.

Issue 9203004: - Remove support for ">>>" operator. (Closed)

Created:
8 years, 11 months ago by Ivan Posva

Modified:
8 years, 11 months ago

Reviewers:
gbracha, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

- Remove support for ">>>" operator. Committed: https://code.google.com/p/dart/source/detail?r=3279 Committed: https://code.google.com/p/dart/source/detail?r=3280

Patch Set 2 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -46 lines)			Patch
M	../tests/corelib/src/CoreRuntimeTypesTest.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/integers.cc	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	vm/ast.cc	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	vm/opt_code_generator_ia32.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	vm/parser.cc	View	1	6 chunks	+7 lines, -19 lines	0 comments	Download
M	vm/scanner.cc	View	1	1 chunk	+3 lines, -8 lines	0 comments	Download
M	vm/token.h	View	1	5 chunks	+7 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Updated the shift operator support to the latest spec. For some reason the CoreRuntimeTypesTest.dart can ...

8 years, 11 months ago (2012-01-13 06:55:42 UTC) #1

hausner

LGTM with a couple of nits. http://codereview.chromium.org/9203004/diff/1/vm/parser.cc File vm/parser.cc (right): http://codereview.chromium.org/9203004/diff/1/vm/parser.cc#newcode2937 vm/parser.cc:2937: (token == Token::kSHR)) ...

8 years, 11 months ago (2012-01-13 07:22:49 UTC) #2

Ivan Posva

8 years, 11 months ago (2012-01-13 09:04:17 UTC) #3

http://codereview.chromium.org/9203004/diff/1/vm/parser.cc
File vm/parser.cc (right):

http://codereview.chromium.org/9203004/diff/1/vm/parser.cc#newcode2937
vm/parser.cc:2937: (token == Token::kSHR)) {
On 2012/01/13 07:22:53, hausner wrote:
> Probably fits on one line now. Also in other places.

Done.

http://codereview.chromium.org/9203004/diff/1/vm/scanner.cc
File vm/scanner.cc (right):

http://codereview.chromium.org/9203004/diff/1/vm/scanner.cc#newcode670
vm/scanner.cc:670: case '>':  // >  >=  >>  >>=  >>>  >>>=
On 2012/01/13 07:22:53, hausner wrote:
> Update the comment please.

Done.

Expand Messages | Collapse Messages