Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 9197015: Move templates to their own directory structure. (Closed)

Created:
8 years, 11 months ago by sra1
Modified:
8 years, 11 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, Jacob
Visibility:
Public.

Description

Move templates to their own directory structure. Templates are now looked up on a set of paths in the 'templates' directory. This should be versatile enough to have separate templates for dom and html and have some shared templates too. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3268

Patch Set 1 #

Patch Set 2 : shorten file names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -639 lines) Patch
M client/dom/scripts/dartdomgenerator.py View 2 chunks +7 lines, -2 lines 0 comments Download
M client/dom/scripts/dartgenerator.py View 1 15 chunks +64 lines, -53 lines 0 comments Download
D client/dom/scripts/template_callback.darttemplate View 1 chunk +0 lines, -6 lines 0 comments Download
D client/dom/scripts/template_frog_dom.darttemplate View 1 chunk +0 lines, -28 lines 0 comments Download
D client/dom/scripts/template_frog_impl.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
D client/dom/scripts/template_html.darttemplate View 1 chunk +0 lines, -67 lines 0 comments Download
D client/dom/scripts/template_interface.darttemplate View 1 chunk +0 lines, -8 lines 0 comments Download
D client/dom/scripts/template_interface_AudioContext.darttemplate View 1 chunk +0 lines, -10 lines 0 comments Download
D client/dom/scripts/template_interface_CSSMatrix.darttemplate View 1 chunk +0 lines, -10 lines 0 comments Download
D client/dom/scripts/template_interface_FileReader.darttemplate View 1 chunk +0 lines, -10 lines 0 comments Download
D client/dom/scripts/template_interface_Point.darttemplate View 1 chunk +0 lines, -10 lines 0 comments Download
D client/dom/scripts/template_interface_WebKitCSSMatrix.darttemplate View 1 chunk +0 lines, -10 lines 0 comments Download
D client/dom/scripts/template_interface_WebKitPoint.darttemplate View 1 chunk +0 lines, -10 lines 0 comments Download
D client/dom/scripts/template_interface_WebSocket.darttemplate View 1 chunk +0 lines, -10 lines 0 comments Download
D client/dom/scripts/template_interface_XMLHttpRequest.darttemplate View 1 chunk +0 lines, -11 lines 0 comments Download
D client/dom/scripts/template_wrapping_dom.darttemplate View 1 chunk +0 lines, -25 lines 0 comments Download
D client/dom/scripts/template_wrapping_dom.js View 1 chunk +0 lines, -345 lines 0 comments Download
D client/dom/scripts/template_wrapping_dom_externs.js View 1 chunk +0 lines, -37 lines 0 comments Download
D client/dom/scripts/template_wrapping_impl.darttemplate View 1 chunk +0 lines, -5 lines 0 comments Download
A + client/dom/templates/callback.darttemplate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/dom/frog/frog_dom.darttemplate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/dom/frog/frog_impl.darttemplate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/dom/interface/interface_AudioContext.darttemplate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/dom/interface/interface_CSSMatrix.darttemplate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/dom/interface/interface_FileReader.darttemplate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/dom/interface/interface_Point.darttemplate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/dom/interface/interface_WebKitCSSMatrix.darttemplate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/dom/interface/interface_WebKitPoint.darttemplate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/dom/interface/interface_WebSocket.darttemplate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/dom/interface/interface_XMLHttpRequest.darttemplate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/dom/interface/wrapping_dom.darttemplate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/dom/wrapping/wrapping_dom.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/dom/wrapping/wrapping_dom_externs.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/dom/wrapping/wrapping_impl.darttemplate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/html/template_html.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/dom/templates/interface.darttemplate View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
8 years, 11 months ago (2012-01-12 23:25:37 UTC) #1
vsm
LGTM, but I think wrapping_dom.darttemplate should be the wrapping directory, not the interface one. Perhaps ...
8 years, 11 months ago (2012-01-12 23:42:20 UTC) #2
sra1
8 years, 11 months ago (2012-01-13 00:25:20 UTC) #3
On 2012/01/12 23:42:20, vsm wrote:
> LGTM, but I think wrapping_dom.darttemplate should be the wrapping directory,
> not the interface one.

This reflects what templates we were actually using during generation.

The wrapping dom entire package is produced from the interfaces and the
implementation.
It is a variant of that weird convention where the interface library imports an
implementation, but in this case the impl lib is flattened into the interface
lib.

I'll see of the implementation can be made 'dominant'.  It will then have to
reach into the interface 'System' to get the classes that define what the whole
library is, which also feels weird.

> 
> Perhaps interface.darttemplate should be in the interface dir?

I expect to move it up and share it with html.


> 
> Also, consider eliminating wrapping_ and interface_ as they are redundant with
> the directory names.

Sure.  But I think the frog generator with interfaces might need templates for
both interfaces and classes in the same lookup path.  Depends on how we deal
with static methods - we might have to make some 'classes' be classes and other
interfaces.

Powered by Google App Engine
This is Rietveld 408576698