Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 9190044: Issue 1140: Tweak relative path for shadowing problems. (Closed)

Created:
8 years, 11 months ago by scheglov
Modified:
8 years, 11 months ago
Reviewers:
codefu
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 1140: Tweak relative path for shadowing problems. http://code.google.com/p/dart/issues/detail?id=1140 This is only tweak for using dart:// protocol where appropriate. Specify or not location of shadowed element is debatable question. R=codefu@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -34 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/Elements.java View 4 chunks +34 lines, -19 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java View 4 chunks +19 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 11 months ago (2012-01-12 16:00:00 UTC) #1
codefu
8 years, 11 months ago (2012-01-12 16:04:15 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698