Issue 9190011: Fix flaky tests on chromium buildbot, by adding a correct fix to test.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9190011: Fix flaky tests on chromium buildbot, by adding a correct fix to test.dart. (Closed)

Created:
8 years, 11 months ago by Bill Hesse

Modified:
8 years, 11 months ago

Reviewers:
Siggi Cherem (dart-lang), Emily Fortuna

CC:
reviews_dartlang.org, Mads Ager (google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix flaky tests on chromium buildbot, by adding a correct fix to test.dart. BUG=dart:1135, dart:1127 TEST=tools/test.dart -cchromium language Committed: https://code.google.com/p/dart/source/detail?r=3197

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	tools/testing/dart/test_runner.dart	View		1 chunk	+7 lines, -6 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

I didn't see your bug report dart:1127 until now. My first fix was buggy, because ...

8 years, 11 months ago (2012-01-11 18:08:10 UTC) #1

Siggi Cherem (dart-lang)

lgtm http://codereview.chromium.org/9190011/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): http://codereview.chromium.org/9190011/diff/1/tools/testing/dart/test_runner.dart#newcode169 tools/testing/dart/test_runner.dart:169: return testCase.isNegative; could we print a warning to ...

8 years, 11 months ago (2012-01-11 18:40:15 UTC) #4

Siggi Cherem (dart-lang)

8 years, 11 months ago (2012-01-11 20:55:15 UTC) #5

http://codereview.chromium.org/9190011/diff/1/tools/testing/dart/test_runner....
File tools/testing/dart/test_runner.dart (right):

http://codereview.chromium.org/9190011/diff/1/tools/testing/dart/test_runner....
tools/testing/dart/test_runner.dart:166: if (line.contains('Gtk-WARNING **:
cannot open display: :99')) {
I just saw the failure here:
http://chromegw.corp.google.com/i/client.dash/builders/frogium-linux-debug/bu...

I believe the problem is that this error shows in stderr, rather than stdout.
I'll be happy to send you a fix.

Expand Messages | Collapse Messages