Issue 9188037: Use test.py instead of test.dart on Windows and MacOS platforms for vm tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9188037: Use test.py instead of test.dart on Windows and MacOS platforms for vm tests. (Closed)

Created:
8 years, 11 months ago by Bill Hesse

Modified:
8 years, 11 months ago

Reviewers:
floitsch, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use test.py instead of test.dart on Windows and MacOS platforms for vm tests. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3243

Patch Set 1 #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	tools/test_wrapper.py	View		1 chunk	+8 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

8 years, 11 months ago (2012-01-12 16:52:15 UTC) #2

LGTM

http://codereview.chromium.org/9188037/diff/1/tools/test_wrapper.py
File tools/test_wrapper.py (right):

http://codereview.chromium.org/9188037/diff/1/tools/test_wrapper.py#newcode24
tools/test_wrapper.py:24: if current_directory == os.path.join(client,
'runtime'):
Add TODO to remove these lines?

Expand Messages | Collapse Messages