Issue 9188032: Allow test.dart dartc/junit_tests to be run from the compiler subdirectory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9188032: Allow test.dart dartc/junit_tests to be run from the compiler subdirectory. (Closed)

Created:
8 years, 11 months ago by Bill Hesse

Modified:
8 years, 11 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow test.dart dartc/junit_tests to be run from the compiler subdirectory. BUG= TEST=cd compiler; ../tools/build.py dartc; ../tools/test.dart -cdartc dartc/junit_tests Committed: https://code.google.com/p/dart/source/detail?r=3237

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -10 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View		3 chunks	+16 lines, -10 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM, with one comment. http://codereview.chromium.org/9188032/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): http://codereview.chromium.org/9188032/diff/1/tools/testing/dart/test_suite.dart#newcode839 tools/testing/dart/test_suite.dart:839: String d8 = '$buildDir/d8${TestUtils.executableSuffix}'; Is ...

8 years, 11 months ago (2012-01-12 14:31:26 UTC) #2

Bill Hesse

8 years, 11 months ago (2012-01-12 14:45:03 UTC) #3

http://codereview.chromium.org/9188032/diff/1/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/9188032/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:839: String d8 =
'$buildDir/d8${TestUtils.executableSuffix}';
On 2012/01/12 14:31:26, ajohnsen wrote:
> Is buildDir absolute since we can do without dartDir?

No, buildDir is relative to the current directory, not relative to dartDir, so
we must use it as a relative path.

Expand Messages | Collapse Messages