Issue 9188004: Issue 1091: Static type warning for setters with non-void return types

Issue 9188004: Issue 1091: Static type warning for setters with non-void return types (Closed)

Created:
8 years, 11 months ago by codefu

Modified:
8 years, 11 months ago

Reviewers:
mmendez, scheglov, zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 1091: Static type warning for setters with non-void return types http://code.google.com/p/dart/issues/detail?id=1091 Spec 0.06 section 7.3 Setters R=zundel BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3196

Patch Set 2 : Language multitest #

Total comments: 2

Patch Set 3 : Nit: shared test description #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -1 line)			Patch
M	compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View		1 chunk	+22 lines, -0 lines	2 comments	Download
A	tests/language/src/Setter3Test.dart	View	1 2	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

zundel

lgtm, one tiny nit http://codereview.chromium.org/9188004/diff/1004/tests/language/src/Setter3Test.dart File tests/language/src/Setter3Test.dart (right): http://codereview.chromium.org/9188004/diff/1004/tests/language/src/Setter3Test.dart#newcode4 tests/language/src/Setter3Test.dart:4: convention is to add a ...

8 years, 11 months ago (2012-01-11 16:16:25 UTC) #2

codefu

http://codereview.chromium.org/9188004/diff/1004/tests/language/src/Setter3Test.dart File tests/language/src/Setter3Test.dart (right): http://codereview.chromium.org/9188004/diff/1004/tests/language/src/Setter3Test.dart#newcode4 tests/language/src/Setter3Test.dart:4: On 2012/01/11 16:16:25, zundel wrote: > convention is to ...

8 years, 11 months ago (2012-01-11 16:21:51 UTC) #3

scheglov

http://codereview.chromium.org/9188004/diff/9/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java File compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java (right): http://codereview.chromium.org/9188004/diff/9/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java#newcode427 compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java:427: * spec requires warnings, so we provide it, but ...

8 years, 11 months ago (2012-01-11 18:15:08 UTC) #6

codefu

8 years, 11 months ago (2012-01-11 18:16:08 UTC) #7

http://codereview.chromium.org/9188004/diff/9/compiler/javatests/com/google/d...
File
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
(right):

http://codereview.chromium.org/9188004/diff/9/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java:427:
* spec requires warnings, so we provide it, but using different constant.
On 2012/01/11 18:15:08, scheglov wrote:
> Comment does not correspond to the method.

Copy and paste error on my part. Will update in a different CL.  Thanks for the
catch.

Expand Messages | Collapse Messages