Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 9186008: Update fling library for changes to DartCompilerListener (Closed)

Created:
8 years, 11 months ago by zundel
Modified:
8 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update fling library for changes to DartCompilerListener http://code.google.com/p/dart/issues/detail?id=1106 Committed: https://code.google.com/p/dart/source/detail?r=3194

Patch Set 1 #

Total comments: 4

Patch Set 2 : Derive from DartCompilerListener.Empty instead of implementing DartCompilerListener #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -33 lines) Patch
M client/fling/src/java/core/com/google/dart/CompileService.java View 1 10 chunks +24 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zundel
This is just to update the library to match your recent changes to DartCompilerListener from ...
8 years, 11 months ago (2012-01-11 16:59:29 UTC) #1
scheglov
http://codereview.chromium.org/9186008/diff/1/client/fling/src/java/core/com/google/dart/CompileService.java File client/fling/src/java/core/com/google/dart/CompileService.java (right): http://codereview.chromium.org/9186008/diff/1/client/fling/src/java/core/com/google/dart/CompileService.java#newcode127 client/fling/src/java/core/com/google/dart/CompileService.java:127: private static class Listener implements DartCompilerListener { I think ...
8 years, 11 months ago (2012-01-11 17:29:07 UTC) #2
zundel
updated patch
8 years, 11 months ago (2012-01-11 17:36:04 UTC) #3
scheglov
8 years, 11 months ago (2012-01-11 17:36:48 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698