Issue 9185046: Move UTF-8 decoder to utils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9185046: Move UTF-8 decoder to utils. (Closed)

Created:
8 years, 11 months ago by ahe

Modified:
8 years, 11 months ago

Reviewers:
jimhug, ngeoffray

CC:
reviews_dartlang.org, Mads Ager (google), Søren Gjesse, jimhug, Jennifer Messerly

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Move UTF-8 decoder to utils. Committed: https://code.google.com/p/dart/source/detail?r=3231

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -178 lines)			Patch
M	dart/frog/leg/scanner/byte_strings.dart	View	1 chunk	+1 line, -66 lines	0 comments	Download
M	dart/frog/leg/scanner/node_scanner_bench.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	dart/frog/leg/scanner/source_list.dart	View	6 chunks	+0 lines, -11 lines	0 comments	Download
M	dart/frog/leg/scanner/vm_scanner_bench.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	dart/utils/utf8/utf8.dart	View	4 chunks	+12 lines, -101 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jimhug

Thanks for putting this in utils! The one thing I'd ask for as a follow-up ...

8 years, 11 months ago (2012-01-12 13:39:06 UTC) #3

ahe

8 years, 11 months ago (2012-01-12 13:45:34 UTC) #4

On 2012/01/12 13:39:06, jimhug wrote:
> Thanks for putting this in utils!  The one thing I'd ask for as a follow-up is
a
> test under utils/tests so that we can ensure it gets tested outside of the
> compiler.  Are there some of your existing tests that you could move there?

Hi Jim,

I agree about tests. I was thinking about (temporarily) putting a test in
corelib, however, I'm currently blocked because the VM build bot doesn't
checkout everything and has a different directory layout. So I cannot refer to
utils/utf8/utf8.dart.

Cheers,
Peter

Expand Messages | Collapse Messages