Issue 9185010: Cancel the compilation if the SSA builder attempts to visit a type annotation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9185010: Cancel the compilation if the SSA builder attempts to visit a type annotation. (Closed)

Created:
8 years, 11 months ago by ahe

Modified:
8 years, 11 months ago

Reviewers:
floitsch, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Cancel the compilation if the SSA builder attempts to visit a type annotation. Committed: https://code.google.com/p/dart/source/detail?r=3191

Patch Set 1 #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -11 lines)			Patch
M	dart/frog/leg/ssa/builder.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	dart/frog/presubmit.py	View	2 chunks	+3 lines, -3 lines	1 comment	Download
M	dart/tests/language/language-leg.status	View	4 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

8 years, 11 months ago (2012-01-11 16:25:42 UTC) #3

LGTM

http://codereview.chromium.org/9185010/diff/1/dart/frog/presubmit.py
File dart/frog/presubmit.py (right):

http://codereview.chromium.org/9185010/diff/1/dart/frog/presubmit.py#newcode161
dart/frog/presubmit.py:161: cmd = test_cmd + ['--component=frogsh', 'leg',
'leg_only']
Thank you!

Expand Messages | Collapse Messages