Issue 9181006: Changed automated testing to run test.dart instead of test.py

lgtm http://codereview.chromium.org/9181006/diff/1002/tools/testing/perf_testing/create_graph.py File tools/testing/perf_testing/create_graph.py (right): http://codereview.chromium.org/9181006/diff/1002/tools/testing/perf_testing/create_graph.py#newcode536 tools/testing/perf_testing/create_graph.py:536: the_os = get_os_directory() the_os => arch?

8 years, 11 months ago (2012-01-11 01:32:07 UTC) #2

Emily Fortuna

http://codereview.chromium.org/9181006/diff/1002/tools/testing/perf_testing/create_graph.py File tools/testing/perf_testing/create_graph.py (right): http://codereview.chromium.org/9181006/diff/1002/tools/testing/perf_testing/create_graph.py#newcode536 tools/testing/perf_testing/create_graph.py:536: the_os = get_os_directory() The directories returned are either "linux" ...

8 years, 11 months ago (2012-01-11 01:38:06 UTC) #3

Siggi Cherem (dart-lang)

8 years, 11 months ago (2012-01-11 01:39:22 UTC) #4

lgtm (oops, I meant to include that before)

http://codereview.chromium.org/9181006/diff/1002/tools/testing/perf_testing/c...
File tools/testing/perf_testing/create_graph.py (right):

http://codereview.chromium.org/9181006/diff/1002/tools/testing/perf_testing/c...
tools/testing/perf_testing/create_graph.py:536: the_os = get_os_directory()
On 2012/01/11 01:38:06, Emily Fortuna wrote:
> The directories returned are either "linux" "macos", or "windows", so os seems
> more appropriate?
> 
> On 2012/01/11 01:32:07, sigmund wrote:
> > the_os => arch?
> 

'the_' looks strange, that's all...

Expand Messages | Collapse Messages

Issue 9181006: Changed automated testing to run test.dart instead of test.py (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages