Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 9168009: Adds extra measure of safety to dartc.sh and dartc_test.sh (Closed)

Created:
8 years, 11 months ago by zundel
Modified:
8 years, 11 months ago
Reviewers:
codefu
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adds extra measure of safety to dartc.sh and dartc_test.sh Adding set -e will cause the script to exit with non-zero status if a shell command exits with non-zero and the status is not checked. We found a case where a problem wasn't being caught and the script kept going in another change. This might help prevent similar problems from going uncaught in the future. Committed: https://code.google.com/p/dart/source/detail?r=3148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M compiler/scripts/dartc.sh View 1 chunk +2 lines, -0 lines 0 comments Download
M compiler/scripts/dartc_test.sh View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zundel
See also http://codereview.chromium.org/9158011/ I'm not sure this change would have caught that error though...
8 years, 11 months ago (2012-01-10 15:19:30 UTC) #1
codefu
8 years, 11 months ago (2012-01-10 15:26:05 UTC) #2
lgtm
I didn't know build bot was using /bin/dash.  Never heard of dash till this
morning!

Powered by Google App Engine
This is Rietveld 408576698