Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 9166016: Introduce the Error object class in the vm. It represents all of the (Closed)

Created:
8 years, 11 months ago by turnidge
Modified:
8 years, 11 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Introduce the Error object class in the vm. It represents all of the things that may go wrong while invoking the dart api. Here are the four types of error: - ApiError = the user misused one of the dart apis - LanguageError = a language-level problem, e.g. compiler error - UnhandledException = an uncaught exception made its way to the embedder - UnwindError = a forced isolate interrupt This cl is the first of a series. I plan to move the point of creation for LanguageErrors into the Parser, etc. I also plan to move the longjmp's out of dart_api_impl.cc. I also also plan to implement UnwindErrors later. (Copied from Issue 9085031 due to subversion problems) Committed: https://code.google.com/p/dart/source/detail?r=3168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+476 lines, -311 lines) Patch
M runtime/vm/dart_api_impl.h View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 71 chunks +169 lines, -200 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger_api_impl.cc View 6 chunks +18 lines, -18 lines 0 comments Download
M runtime/vm/object.h View 5 chunks +72 lines, -14 lines 0 comments Download
M runtime/vm/object.cc View 10 chunks +92 lines, -39 lines 0 comments Download
M runtime/vm/object_store.h View 3 chunks +0 lines, -12 lines 0 comments Download
M runtime/vm/object_store.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/raw_object.h View 3 chunks +42 lines, -8 lines 0 comments Download
M runtime/vm/raw_object.cc View 2 chunks +25 lines, -3 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 2 chunks +56 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
turnidge
8 years, 11 months ago (2012-01-10 21:35:22 UTC) #1
TBR -iposva

This is the same cl that you have already reviewed but patched into a new
client.

Todd

Powered by Google App Engine
This is Rietveld 408576698