Issue 9166013: Add check for repeated options on test.dart command line. Revert debugging commit r3110.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9166013: Add check for repeated options on test.dart command line. Revert debugging commit r3110. (Closed)

Created:
8 years, 11 months ago by Bill Hesse

Modified:
8 years, 11 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add check for repeated options on test.dart command line. Revert debugging commit r3110. Also fix bug where unknown options would crash test.dart. BUG= TEST=tools/test.dart --flag foo --flag bar --mispellede Committed: https://code.google.com/p/dart/source/detail?r=3195

Patch Set 1 #

Total comments: 1

Patch Set 2 : Make error message more descriptive. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -21 lines)			Patch
	M	tools/testing/dart/test_options.dart	View	1	7 chunks	+27 lines, -16 lines	0 comments	Download
	M	tools/testing/dart/test_suite.dart	View		1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

I'm reverting the disabling of multiple vmOptions I did last night, and printing a warning ...

8 years, 11 months ago (2012-01-10 20:16:57 UTC) #1

Emily Fortuna

8 years, 11 months ago (2012-01-10 23:24:00 UTC) #2

lgtm!

http://codereview.chromium.org/9166013/diff/1/tools/testing/dart/test_options...
File tools/testing/dart/test_options.dart (right):

http://codereview.chromium.org/9166013/diff/1/tools/testing/dart/test_options...
tools/testing/dart/test_options.dart:239: print('Multiple "--${spec.name}" flags
on command line');
Slightly more informative error message:
print ('Error: test.dart does not accept multiple[...]')  ?

Expand Messages | Collapse Messages