Issue 9166012: Create temporary handles in the snapshot object during initialization and use them instead of cre...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9166012: Create temporary handles in the snapshot object during initialization and use them instead of cre... (Closed)

Created:
8 years, 11 months ago by siva

Modified:
8 years, 11 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Create temporary handles in the snapshot object during initialization and use them instead of creating temporary handles in each deserialization function. Committed: https://code.google.com/p/dart/source/detail?r=3271

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -50 lines)			Patch
M	vm/raw_object_snapshot.cc	View	6 chunks	+14 lines, -23 lines	0 comments	Download
M	vm/snapshot.h	View	4 chunks	+15 lines, -5 lines	0 comments	Download
M	vm/snapshot.cc	View	5 chunks	+31 lines, -22 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM -ip

Expand Messages | Collapse Messages