Issue 1105: Duplicate initialization should have a compile error

Issue 1105: Duplicate initialization should have a compile error
http://code.google.com/p/dart/issues/detail?id=1105
7.5.1
It is a compile-time error if more than one initializer corresponding to a
given instance variable appears in k’s initializer list. It is a
compile-time error if k’s initializer list contains an initializer for a
variable that is initialized by means of an initializing formal of k.
R=zundel,mmendez
BUG=1105
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3152

[codefu, 2012-01-10 14:42:44]

http://codereview.chromium.org/9166006/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/Resolver.java (left):

http://codereview.chromium.org/9166006/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/Resolver.java:597: &&
!finalsNeedingInitializing.equals(initalizedFinals)) {
I removed this line because I felt that, if we're already going to go over the
set once to test if its not equal and then again to find and report errors...
why not just have the one loop.  Note: initializedFields now represents a set
that includes finals and non-finals.

[zundel, 2012-01-10 15:48:24]

lgtm

http://codereview.chromium.org/9166006/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right):

http://codereview.chromium.org/9166006/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/Resolver.java:562: Set<Element>
initializedFields = Sets.newHashSet();
Could this be tightened to a FieldElement?

[codefu, 2012-01-10 15:51:02]

http://codereview.chromium.org/9166006/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right):

http://codereview.chromium.org/9166006/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/Resolver.java:562: Set<Element>
initializedFields = Sets.newHashSet();
On 2012/01/10 15:48:24, zundel wrote:
> Could this be tightened to a FieldElement?

I tried, but the call to resolveInitializers() looks at:
initializer.getName().getTargetSymbol()
which returns just an Element. I could cast at that point and tighten up the set
though.  Opinions?

[mmendez, 2012-01-10 16:28:23]

lgtm

Might as well tighten if you can.

On 2012/01/10 15:51:02, codefu wrote:
>
http://codereview.chromium.org/9166006/diff/1/compiler/java/com/google/dart/c...
> File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right):
> 
>
http://codereview.chromium.org/9166006/diff/1/compiler/java/com/google/dart/c...
> compiler/java/com/google/dart/compiler/resolver/Resolver.java:562:
Set<Element>
> initializedFields = Sets.newHashSet();
> On 2012/01/10 15:48:24, zundel wrote:
> > Could this be tightened to a FieldElement?
> 
> I tried, but the call to resolveInitializers() looks at:
> initializer.getName().getTargetSymbol()
> which returns just an Element. I could cast at that point and tighten up the
set
> though.  Opinions?