Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 9162001: Updating crufty tests, remove invalid TryCatch8NegativeTest (Closed)

Created:
8 years, 11 months ago by zundel
Modified:
8 years, 11 months ago
Reviewers:
gbracha
CC:
reviews_dartlang.org
Visibility:
Public.

Description

TryCatch8NegativeTest looks like it is out of sync with the spec, other TryCatch?NegativeTest cases have outdated or illegal syntax other than the true object of the test. Committed: https://code.google.com/p/dart/source/detail?r=3115

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -61 lines) Patch
M tests/language/src/TryCatch2NegativeTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/src/TryCatch3NegativeTest.dart View 2 chunks +2 lines, -9 lines 1 comment Download
M tests/language/src/TryCatch4NegativeTest.dart View 2 chunks +2 lines, -8 lines 0 comments Download
M tests/language/src/TryCatch5NegativeTest.dart View 2 chunks +2 lines, -8 lines 0 comments Download
D tests/language/src/TryCatch8NegativeTest.dart View 1 chunk +0 lines, -35 lines 2 comments Download

Messages

Total messages: 2 (0 generated)
zundel
I noticed these tests were failing dartc for the wrong reason (can't specify a default ...
8 years, 11 months ago (2012-01-09 21:39:37 UTC) #1
gbracha
8 years, 11 months ago (2012-01-09 21:56:44 UTC) #2
lgtm modulo 1 comment

http://codereview.chromium.org/9162001/diff/1/tests/language/src/TryCatch3Neg...
File tests/language/src/TryCatch3NegativeTest.dart (right):

http://codereview.chromium.org/9162001/diff/1/tests/language/src/TryCatch3Neg...
tests/language/src/TryCatch3NegativeTest.dart:7: 
it might be good to be more specific: duplicate declaration of variable "e" in
catch clause in method Helper.f1().

Powered by Google App Engine
This is Rietveld 408576698