Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 9152018: Remove everything to do with snippets (Closed)

Created:
8 years, 11 months ago by sra1
Modified:
8 years, 11 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove everything to do with snippets We don't use snippets and there are other mechanisms that can get the same effect. IDL-side modifications can be expressed as supplemental IDL; generated-code-side modifications as templates or tweaks to the generator. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -177 lines) Patch
M client/dom/scripts/dartdomgenerator.py View 1 chunk +0 lines, -1 line 0 comments Download
M client/dom/scripts/dartgenerator.py View 7 chunks +3 lines, -27 lines 0 comments Download
M client/dom/scripts/dartgenerator_test.py View 2 chunks +0 lines, -4 lines 0 comments Download
M client/dom/scripts/databasebuilder.py View 3 chunks +0 lines, -8 lines 0 comments Download
M client/dom/scripts/databasebuilder_test.py View 13 chunks +12 lines, -20 lines 0 comments Download
M client/dom/scripts/idlnode.py View 2 chunks +0 lines, -9 lines 0 comments Download
M client/dom/scripts/idlnode_test.py View 1 chunk +0 lines, -8 lines 0 comments Download
M client/dom/scripts/idlparser.py View 2 chunks +1 line, -8 lines 0 comments Download
M client/dom/scripts/idlparser_test.py View 1 chunk +0 lines, -8 lines 0 comments Download
M client/dom/scripts/idlrenderer.py View 2 chunks +0 lines, -7 lines 0 comments Download
D client/dom/scripts/snippet_manager.py View 1 chunk +0 lines, -77 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
tbr
8 years, 11 months ago (2012-01-09 23:08:35 UTC) #1
vsm
8 years, 11 months ago (2012-01-09 23:45:16 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698