Issue 9152013: Get dartdoc running again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9152013: Get dartdoc running again. (Closed)

Created:
8 years, 11 months ago by nweiz

Modified:
8 years, 11 months ago

Reviewers:
jimhug, Bob Nystrom

CC:
reviews_dartlang.org, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Get dartdoc running again. TBR Committed: https://code.google.com/p/dart/source/detail?r=3116

Patch Set 1 #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	frog/member.dart	View		1 chunk	+7 lines, -0 lines	1 comment	Download
	M	utils/dartdoc/dartdoc.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nweiz

I'm submitting this because Bob's having trouble getting his build working.

8 years, 11 months ago (2012-01-09 22:33:27 UTC) #1

Bob Nystrom

8 years, 11 months ago (2012-01-09 22:38:54 UTC) #2

One nit, otherwise LGTM.

http://codereview.chromium.org/9152013/diff/1/frog/member.dart
File frog/member.dart (right):

http://codereview.chromium.org/9152013/diff/1/frog/member.dart#newcode31
frog/member.dart:31: if (definition.value.span.start == definition.span.start) {
Should use hasDefaultValue here.

Expand Messages | Collapse Messages